NAS-132722 / 25.04 / Add fibre channel ports list and form

[denysbutenko]

Changes:

Add fibre channel ports list and form

Testing:

Check Fibre Channel Ports tab on iSCSI share page

[bugclerk]

Jira URL: https://ixsystems.atlassian.net/browse/NAS-132722

[codecov]

Codecov Report

Attention: Patch coverage is 93.38235% with 9 lines in your changes missing coverage. Please review.

Project coverage is 82.68%. Comparing base (a78dd27) to head (249aa89).
Report is 1 commits behind head on master.

✅ All tests successful. No failed tests found.

Files with missing lines	Patch %	Lines
...bre-channel-ports/fibre-channel-ports.component.ts	91.54%	6 Missing ⚠️
...l-ports-form/fibre-channel-ports-form.component.ts	95.38%	3 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master   #11146      +/-   ##
==========================================
+ Coverage   82.64%   82.68%   +0.04%     
==========================================
  Files        1651     1652       +1     
  Lines       58181    58313     +132     
  Branches     5988     5997       +9     
==========================================
+ Hits        48083    48218     +135     
+ Misses      10098    10095       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[undsoft]

• When I remove an item from the table, I need to refresh the page to see change.
• Create New in target doesn't seem to work. We can remove this option.

I'm also now not sure if this is how the form is supposed to work, but it's okay to merge this and fix later if necessary.

[denysbutenko]

• When I remove an item from the table, I need to refresh the page to see change.
• Create New in target doesn't seem to work. We can remove this option.

I'm also now not sure if this is how the form is supposed to work, but it's okay to merge this and fix later if necessary.

@undsoft

1. Seems like long delay and no visual indicator. This component uses dataProvider.isLoading$, and the state is not changed when load() is called. I'll create a ticket to look at it.
2. I was able to create fibre channel port on m50. Perhaps we may need to adjust condition when show Add button. Let's do it later.

[bugclerk]

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.