Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NAS-132914 / 25.04 / Expose force_remove_ix_volumes flag on app deletion #11159

Merged
merged 2 commits into from
Dec 11, 2024

Conversation

undsoft
Copy link
Collaborator

@undsoft undsoft commented Dec 9, 2024

Changes:

Exposes new checkbox when removing an app that has ixVolumes.

Downstream

Affects Reasoning
Documentation New option when removing an app.

@undsoft undsoft requested a review from a team as a code owner December 9, 2024 13:32
@undsoft undsoft requested review from bvasilenko and removed request for a team December 9, 2024 13:32
@bugclerk bugclerk changed the title NAS-132914: Expose force_remove_ix_volumes flag on app deletion NAS-132914 / 25.04 / Expose force_remove_ix_volumes flag on app deletion Dec 9, 2024
@bugclerk
Copy link
Contributor

bugclerk commented Dec 9, 2024

Copy link

codecov bot commented Dec 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.68%. Comparing base (8b4d4e2) to head (84a0e97).
Report is 1 commits behind head on master.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #11159      +/-   ##
==========================================
- Coverage   82.68%   82.68%   -0.01%     
==========================================
  Files        1652     1652              
  Lines       58335    58334       -1     
  Branches     6001     5998       -3     
==========================================
- Hits        48237    48234       -3     
- Misses      10098    10100       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@bvasilenko bvasilenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected

@undsoft undsoft enabled auto-merge (squash) December 11, 2024 17:25
@undsoft undsoft merged commit ecba8b5 into master Dec 11, 2024
11 checks passed
@undsoft undsoft deleted the NAS-132914 branch December 11, 2024 17:53
@bugclerk
Copy link
Contributor

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.

@truenas truenas locked as resolved and limited conversation to collaborators Dec 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants