Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NAS-132920 / 24.10.2 / New cloud backup option: absolute_paths (by AlexKarpov98) #11168

Merged
merged 2 commits into from
Dec 13, 2024

Conversation

bugclerk
Copy link
Contributor

Automatic cherry-pick failed. Please resolve conflicts by running:

git reset --hard HEAD~1
git cherry-pick -x 86caa83b5d196fabe966fd458ae4195eea9c74c9
git cherry-pick -x 0c5945b895fab4dc343e5e5b7a193f310afe35b2
git cherry-pick -x 96e65a98f2d389c9b32e1d3bfd93026358604b97

If the original PR was merged via a squash, you can just cherry-pick the squashed commit:

git reset --hard HEAD~1
git cherry-pick -x 3f625f8b4c16e268247b482c627737c5ded80760

Testing: see ticket.

Original PR: #11165
Jira URL: https://ixsystems.atlassian.net/browse/NAS-132920

@AlexKarpov98 AlexKarpov98 marked this pull request as ready for review December 12, 2024 16:25
@AlexKarpov98 AlexKarpov98 requested a review from a team as a code owner December 12, 2024 16:25
@AlexKarpov98 AlexKarpov98 requested review from undsoft and removed request for a team December 12, 2024 16:25
@AlexKarpov98 AlexKarpov98 enabled auto-merge (squash) December 12, 2024 16:26
Copy link

codecov bot commented Dec 12, 2024

Codecov Report

Attention: Patch coverage is 90.47619% with 4 lines in your changes missing coverage. Please review.

Please upload report for BASE (stable/electriceel@0d8c575). Learn more about missing BASE report.

Files with missing lines Patch % Lines
...p/cloud-backup-form/cloud-backup-form.component.ts 90.47% 4 Missing ⚠️
Additional details and impacted files
@@                  Coverage Diff                  @@
##             stable/electriceel   #11168   +/-   ##
=====================================================
  Coverage                      ?   79.96%           
=====================================================
  Files                         ?     1572           
  Lines                         ?    51469           
  Branches                      ?     5940           
=====================================================
  Hits                          ?    41158           
  Misses                        ?    10311           
  Partials                      ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@AlexKarpov98 AlexKarpov98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ported.

@AlexKarpov98 AlexKarpov98 merged commit 41a20f6 into stable/electriceel Dec 13, 2024
9 checks passed
@AlexKarpov98 AlexKarpov98 deleted the NAS-132920-24.10.2 branch December 13, 2024 08:03
@bugclerk
Copy link
Contributor Author

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.

@truenas truenas locked as resolved and limited conversation to collaborators Dec 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants