Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NAS-133066 / 25.04 / Use computed signals more #11180

Merged
merged 1 commit into from
Dec 13, 2024
Merged

NAS-133066 / 25.04 / Use computed signals more #11180

merged 1 commit into from
Dec 13, 2024

Conversation

undsoft
Copy link
Collaborator

@undsoft undsoft commented Dec 13, 2024

Testing:

Code review is enough.

@undsoft undsoft requested a review from a team as a code owner December 13, 2024 10:55
@undsoft undsoft requested review from bvasilenko and removed request for a team December 13, 2024 10:55
@bugclerk bugclerk changed the title NAS-133066: Use computed signals more NAS-133066 / 25.04 / Use computed signals more Dec 13, 2024
@bugclerk
Copy link
Contributor

Copy link

codecov bot commented Dec 13, 2024

Codecov Report

Attention: Patch coverage is 93.90244% with 5 lines in your changes missing coverage. Please review.

Project coverage is 82.70%. Comparing base (3490c7c) to head (5942bb2).
Report is 2 commits behind head on master.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...disk-details-panel/disk-details-panel.component.ts 0.00% 4 Missing ⚠️
...ponents/ix-table-pager/ix-table-pager.component.ts 90.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master   #11180   +/-   ##
=======================================
  Coverage   82.69%   82.70%           
=======================================
  Files        1651     1651           
  Lines       58329    58325    -4     
  Branches     6004     6003    -1     
=======================================
  Hits        48235    48235           
+ Misses      10094    10090    -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@AlexKarpov98 AlexKarpov98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More computed() signals are used 👌

@undsoft undsoft enabled auto-merge (squash) December 13, 2024 11:51
@undsoft undsoft merged commit 432ea4b into master Dec 13, 2024
9 checks passed
@undsoft undsoft deleted the NAS-133066 branch December 13, 2024 12:13
@bugclerk
Copy link
Contributor

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.

@truenas truenas locked as resolved and limited conversation to collaborators Dec 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants