Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made RequiredByAll tag light red and added tooltip to explain what it means #52

Merged
merged 1 commit into from
Aug 13, 2023

Conversation

Buckminsterfullerene02
Copy link
Contributor

Because my partner is your typical "dumb user" (shh) and doesn't understand what RequiredByAll is. She installed one as host and it took me a little bit to figure out why the game was crashing for me, and I think this extra clarification is nice QoL.

@trumank trumank added the C-enhancement Category: new feature or request label Aug 12, 2023
Copy link
Owner

@trumank trumank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For sake of completion, the other tags should get descriptions too. Are you aware of a mod.io tag summary somewhere that could be used?

src/gui/mod.rs Outdated Show resolved Hide resolved
@Buckminsterfullerene02
Copy link
Contributor Author

For sake of completion, the other tags should get descriptions too.

I think it only makes sense for Optional to get a description too. Maybe Verified/Approved/Sandbox too, but I think the others are definately self-explanatory enough to not need any.

Are you aware of a mod.io tag summary somewhere that could be used?

No I am not aware of a mod.io tag summary, is that from the mod.io API? I had a look at ModTag object and there is no field for tag description.

@trumank trumank force-pushed the master branch 3 times, most recently from a81877f to dd0d98d Compare August 13, 2023 01:17
@trumank trumank merged commit 3904acc into trumank:master Aug 13, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-enhancement Category: new feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants