-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cve): update columns #184
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- As described in the spreadsheet I think the "Advisories" Page will be removed. So rather than fixing issues there, we might take the opportunity and delete the directories:
- /client/src/app/pages/advisory-details
- /client/src/app/pages/advisory
And also remove the Advisory from the Routes + remove it from the sidebar. What do you think? Or is it too premature to do it? I'll leave that up to you.
I'll add more comments to the other lines in a moment :)
client/src/app/pages/vulnerability-list/vulnerability-context.tsx
Outdated
Show resolved
Hide resolved
client/src/app/pages/vulnerability-list/vulnerability-table.tsx
Outdated
Show resolved
Hide resolved
@carlosthe19916 thanks for your review, I've made the changes it builds fine now. Looking at a few things I'm missing like
Given that we are still making a lot of changes to the design are we 100% sure we won't want to reuse that code? I don't mind either way.
Yes, no issues with autocomplete though it's not 100% happy. Not blocking me though so I'm not worrying about it for now. |
fix: column keys add published column
@kahboom I had a chat with our PM @mid998 and we agreed to remove the "Advisory" from the left sidebar. But let's do it in a separate PR as it will be easier to track it if at any point we need to revisit the deleted code |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks @kahboom
relates to #171
Still need to add the Published column
and check the CVSS column.