Skip to content

Commit

Permalink
fix: don't check if the bucket exists.
Browse files Browse the repository at this point in the history
Performing an "exists" check requires the s3:ListAllMyBuckets
permission. Which feels excessive for such a simple check.

Closes: #1038
  • Loading branch information
ctron committed Nov 22, 2024
1 parent 205ed5f commit 1e9b3e9
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion modules/storage/src/service/s3.rs
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,6 @@ impl S3Backend {
CONTENT_ENCODING,
HeaderValue::from_str(&compression.to_string())?,
)]))?;
assert!(bucket.exists().await?, "S3 bucket not found");
log::info!(
"Using S3 bucket '{}' in '{}' for doc storage",
bucket.name,
Expand Down

0 comments on commit 1e9b3e9

Please sign in to comment.