Fix Java JVM leak (#4092)

codegen/lib/templates/java/class.erb

@@ -96,32 +96,10 @@ public final class <%= entity.name %> {
             throw new InvalidParameterException();
         }
 
-        <%= entity.name %>PhantomReference.register(this, nativeHandle);
+        GenericPhantomReference.register(someObject, someHandle, handle -> {
+            nativeDelete(nativeHandle);
+        });
     }
 
 <%- end -%>
 }
-<%  unless entity.methods.select{ |x| x.name == "Delete" }.empty? -%>
-class <%= entity.name %>PhantomReference extends java.lang.ref.PhantomReference<<%= entity.name %>> {
-    private static java.util.Set<<%= entity.name %>PhantomReference> references = new HashSet<<%= entity.name %>PhantomReference>();
-    private static java.lang.ref.ReferenceQueue<<%= entity.name %>> queue = new java.lang.ref.ReferenceQueue<<%= entity.name %>>();
-    private long nativeHandle;
-
-    private <%= entity.name %>PhantomReference(<%= entity.name %> referent, long nativeHandle) {
-        super(referent, queue);
-        this.nativeHandle = nativeHandle;
-    }
-
-    static void register(<%= entity.name %> referent, long nativeHandle) {
-        references.add(new <%= entity.name %>PhantomReference(referent, nativeHandle));
-    }
-
-    public static void doDeletes() {
-        <%= entity.name %>PhantomReference ref = (<%= entity.name %>PhantomReference) queue.poll();
-        for (; ref != null; ref = (<%= entity.name %>PhantomReference) queue.poll()) {
-            <%= entity.name %>.nativeDelete(ref.nativeHandle);
-            references.remove(ref);
-        }
-    }
-}
-<%  end -%>

kotlin/gradle/libs.versions.toml

@@ -9,6 +9,10 @@ kotlin = "1.8.21"
 agp = "8.0.0"
 wire = "4.5.6"
 
+androidx-test-runner = "1.5.2"
+
 [libraries]
 wire-runtime = { module = "com.squareup.wire:wire-runtime", version.ref = "wire" }
 wire-compiler = { module = "com.squareup.wire:wire-compiler", version.ref = "wire" }
+
+androidx-test-runner = { module = "androidx.test:runner", version.ref = "androidx-test-runner" }

kotlin/wallet-core-kotlin/build.gradle.kts

@@ -58,7 +58,7 @@ kotlin {
             }
         }
 
-        getByName("commonTest") {
+        val commonTest by getting {
             dependencies {
                 implementation(kotlin("test"))
             }
@@ -85,6 +85,13 @@ kotlin {
                 implementation(npm(name = "webpack", version = "5.89.0"))
             }
         }
+
+        getByName("androidInstrumentedTest") {
+            dependsOn(commonTest)
+            dependencies {
+                implementation(libs.androidx.test.runner)
+            }
+        }
     }
 
     nativeTargets.forEach { nativeTarget ->
@@ -119,6 +126,8 @@ android {
                 arguments += listOf("-DCMAKE_BUILD_TYPE=Release", "-DKOTLIN=True", "-DTW_UNITY_BUILD=ON")
             }
         }
+
+        testInstrumentationRunner = "androidx.test.runner.AndroidJUnitRunner"
     }
 
     buildFeatures {
@@ -132,12 +141,6 @@ android {
         viewBinding = false
     }
 
-    androidComponents {
-        beforeVariants {
-            it.enable = it.name == "release"
-        }
-    }
-
     externalNativeBuild {
         cmake {
             version = libs.versions.android.cmake.get()

kotlin/wallet-core-kotlin/src/androidInstrumentedTest/kotlin/com/trustwallet/core/LibLoader.kt

@@ -0,0 +1,7 @@
+package com.trustwallet.core
+
+actual object LibLoader {
+    actual fun loadLibrary() {
+        System.loadLibrary("TrustWalletCore")
+    }
+}

kotlin/wallet-core-kotlin/src/androidUnitTest/kotlin/com/trustwallet/core/LibLoader.kt

@@ -2,6 +2,6 @@ package com.trustwallet.core
 
 actual object LibLoader {
     actual fun loadLibrary() {
-        throw NotImplementedError()
+        System.loadLibrary("TrustWalletCore")
     }
 }