feat:No changes made in the pull request. #129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Warning Walkthrough skippedFile diffs could not be summarized. Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
coderabbitai
bot
changed the title
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 3
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (11)
src/libs/Cohere/Generated/Cohere.CohereApi.Chat.g.csis excluded by!**/generated/**src/libs/Cohere/Generated/Cohere.CohereApi.Chatv2.g.csis excluded by!**/generated/**src/libs/Cohere/Generated/Cohere.ICohereApi.Chat.g.csis excluded by!**/generated/**src/libs/Cohere/Generated/Cohere.ICohereApi.Chatv2.g.csis excluded by!**/generated/**src/libs/Cohere/Generated/Cohere.Models.ChatRequest.g.csis excluded by!**/generated/**src/libs/Cohere/Generated/Cohere.Models.ChatRequestPromptTruncation.g.csis excluded by!**/generated/**src/libs/Cohere/Generated/Cohere.Models.ChatRequestSafetyMode.g.csis excluded by!**/generated/**src/libs/Cohere/Generated/Cohere.Models.Chatv2Request.g.csis excluded by!**/generated/**src/libs/Cohere/Generated/Cohere.Models.Chatv2RequestSafetyMode.g.csis excluded by!**/generated/**src/libs/Cohere/Generated/Cohere.Models.CitationOptions.g.csis excluded by!**/generated/**src/libs/Cohere/Generated/Cohere.Models.CitationOptionsMode.g.csis excluded by!**/generated/**
📒 Files selected for processing (1)
src/libs/Cohere/openapi.yaml(4 hunks)
🔥 Files not summarized due to errors (1)
- src/libs/Cohere/openapi.yaml: Error: Server error: no LLM provider could handle the message
🔇 Additional comments (1)
src/libs/Cohere/openapi.yaml (1)
82-82: Well-documented prompt truncation parameter!
The documentation clearly explains the behavior of each truncation mode and includes valuable deployment compatibility information. This helps developers choose the appropriate mode based on their deployment environment.
| @@ -204,7 +204,7 @@ paths: | |||
| - CONTEXTUAL | |||
| - STRICT | |||
| - NONE | |||
| description: "Used to select the [safety instruction](https://docs.cohere.com/docs/safety-modes) inserted into the prompt. Defaults to `CONTEXTUAL`.\nWhen `NONE` is specified, the safety instruction will be omitted.\n\nSafety modes are not yet configurable in combination with `tools`, `tool_results` and `documents` parameters.\n\n**Note**: This parameter is only compatible with models [Command R 08-2024](https://docs.cohere.com/docs/command-r#august-2024-release), [Command R+ 08-2024](https://docs.cohere.com/docs/command-r-plus#august-2024-release) and newer.\n\nCompatible Deployments: Cohere Platform, Azure, AWS Sagemaker/Bedrock, Private Deployments\n" | |||
| description: "Used to select the [safety instruction](https://docs.cohere.com/docs/safety-modes) inserted into the prompt. Defaults to `CONTEXTUAL`.\nWhen `NONE` is specified, the safety instruction will be omitted.\n\nSafety modes are not yet configurable in combination with `tools`, `tool_results` and `documents` parameters.\n\n**Note**: This parameter is only compatible with models [Command R 08-2024](https://docs.cohere.com/docs/command-r#august-2024-release), [Command R+ 08-2024](https://docs.cohere.com/docs/command-r-plus#august-2024-release) and newer.\n\n**Note**: `command-r7b-12-2024` only supports `\"CONTEXTUAL\"` and `\"STRICT\"` modes.\n\nCompatible Deployments: Cohere Platform, Azure, AWS Sagemaker/Bedrock, Private Deployments\n" | |||
There was a problem hiding this comment.
Inconsistent safety mode enum values
There's an inconsistency in the safety mode enum values between different parts of the API specification:
- This section uses
NONEas the enum value - Another section (line 805) uses
OFFfor the same functionality
This inconsistency could lead to confusion. Consider standardizing on one term throughout the API specification.
| @@ -802,7 +802,7 @@ | |||
| - CONTEXTUAL | |||
| - STRICT | |||
| - OFF | |||
| description: "Used to select the [safety instruction](https://docs.cohere.com/v2/docs/safety-modes) inserted into the prompt. Defaults to `CONTEXTUAL`.\nWhen `OFF` is specified, the safety instruction will be omitted.\n\nSafety modes are not yet configurable in combination with `tools`, `tool_results` and `documents` parameters.\n\n**Note**: This parameter is only compatible with models [Command R 08-2024](https://docs.cohere.com/v2/docs/command-r#august-2024-release), [Command R+ 08-2024](https://docs.cohere.com/v2/docs/command-r-plus#august-2024-release) and newer.\n" | |||
| description: "Used to select the [safety instruction](https://docs.cohere.com/v2/docs/safety-modes) inserted into the prompt. Defaults to `CONTEXTUAL`.\nWhen `OFF` is specified, the safety instruction will be omitted.\n\nSafety modes are not yet configurable in combination with `tools`, `tool_results` and `documents` parameters.\n\n**Note**: This parameter is only compatible with models [Command R 08-2024](https://docs.cohere.com/v2/docs/command-r#august-2024-release), [Command R+ 08-2024](https://docs.cohere.com/v2/docs/command-r-plus#august-2024-release) and newer.\n\n**Note**: `command-r7b-12-2024` only supports `\"CONTEXTUAL\"` and `\"STRICT\"` modes.\n" | |||
There was a problem hiding this comment.
🛠️ Refactor suggestion
Clarify API version differences
The documentation links to v2 docs and uses different enum values (OFF instead of NONE) compared to the previous section. If these differences are intentional due to API versioning, consider:
- Adding a note explaining the version-specific differences
- Clearly marking which version each enum value belongs to
| @@ -12218,7 +12218,7 @@ | |||
| - ACCURATE | |||
| - OFF | |||
| type: string | |||
| description: "Defaults to `\"accurate\"`.\nDictates the approach taken to generating citations as part of the RAG flow by allowing the user to specify whether they want `\"accurate\"` results, `\"fast\"` results or no results.\n" | |||
| description: "Defaults to `\"accurate\"`.\nDictates the approach taken to generating citations as part of the RAG flow by allowing the user to specify whether they want `\"accurate\"` results, `\"fast\"` results or no results.\n\n**Note**: `command-r7b-12-2024` only supports `\"fast\"` and `\"off\"` modes. Its default is `\"fast\"`.\n" | |||
There was a problem hiding this comment.
Fix case inconsistency in citation modes
There's a case mismatch between the enum values and their usage in the description:
- Enum values use uppercase:
ACCURATE,OFF - Description uses lowercase with quotes:
"accurate","fast","off"
Additionally, the enum values don't include FAST even though it's mentioned in the description as a valid option.
Consider:
- Standardizing the case usage
- Adding the missing
FASTenum value
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.