-
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat:Update OpenAPI Specification for Instill AI API with New Endpoints and Enhancements #56
Conversation
WalkthroughThe changes involve significant updates to the OpenAPI specification for the Instill AI API, introducing new endpoints for agent and tool management, along with enhancements to existing endpoints. New paths allow for listing, creating, updating, and deleting agents and tools. Additionally, schema definitions have been expanded to include new components for agents, along with updates to existing schemas for improved clarity and functionality. Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (5)
src/libs/Instill/openapi.yaml (5)
387-419
: Consider adding pagination parameters to ListAgents endpointThe GET /agents endpoint should include pagination parameters (pageSize, pageToken) for better scalability when dealing with large datasets.
parameters: - name: namespaceId in: path description: The app's owner(namespaces). required: true schema: type: string + - name: pageSize + in: query + description: "The maximum number of agents to return. Default is 10, maximum is 100." + schema: + type: integer + format: int32 + - name: pageToken + in: query + description: "Token for pagination" + schema: + type: string
Line range hint
101-146
: Consider adding rate limiting headers to responsesFor better client integration, consider adding standard rate limiting response headers (X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Reset).
995-1027
: Consider adding filtering capabilities to ListTools endpointTo improve usability, consider adding filter parameters to allow clients to filter tools by type, status, or other relevant criteria.
parameters: + - name: filter + in: query + description: "Filter expression following AIP-160 syntax" + schema: + type: string
6196-6239
: Consider adding validation constraints to Agent schemaThe Agent schema could benefit from additional validation constraints for fields like displayName (e.g., max length, pattern).
displayName: type: string description: The agent display name. + maxLength: 100 + pattern: "^[a-zA-Z0-9-_ ]+$"
10122-10132
: Consider adding validation for Tool configuration valuesThe Tool schema's config property could benefit from additional validation for the string values.
config: type: object additionalProperties: - type: string + type: string + maxLength: 1000 + minLength: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
⛔ Files ignored due to path filters (56)
src/libs/Instill/Generated/Instill.AppClient.AppPublicServiceCreateAgent.g.cs
is excluded by!**/generated/**
src/libs/Instill/Generated/Instill.AppClient.AppPublicServiceDeleteAgent.g.cs
is excluded by!**/generated/**
src/libs/Instill/Generated/Instill.AppClient.AppPublicServiceDeleteApp.g.cs
is excluded by!**/generated/**
src/libs/Instill/Generated/Instill.AppClient.AppPublicServiceGetPlaygroundConversation.g.cs
is excluded by!**/generated/**
src/libs/Instill/Generated/Instill.AppClient.AppPublicServiceListAgents.g.cs
is excluded by!**/generated/**
src/libs/Instill/Generated/Instill.AppClient.AppPublicServiceListChats.g.cs
is excluded by!**/generated/**
src/libs/Instill/Generated/Instill.AppClient.AppPublicServiceListTools.g.cs
is excluded by!**/generated/**
src/libs/Instill/Generated/Instill.AppClient.AppPublicServiceRestartPlaygroundConversation.g.cs
is excluded by!**/generated/**
src/libs/Instill/Generated/Instill.AppClient.AppPublicServiceUpdateAgent.g.cs
is excluded by!**/generated/**
src/libs/Instill/Generated/Instill.AppClient.AppPublicServiceUpdateApp.g.cs
is excluded by!**/generated/**
src/libs/Instill/Generated/Instill.AppClient.AppPublicServiceUpdateChat.g.cs
is excluded by!**/generated/**
src/libs/Instill/Generated/Instill.AppClient.AppPublicServiceUpdateConversation.g.cs
is excluded by!**/generated/**
src/libs/Instill/Generated/Instill.IAppClient.AppPublicServiceCreateAgent.g.cs
is excluded by!**/generated/**
src/libs/Instill/Generated/Instill.IAppClient.AppPublicServiceDeleteAgent.g.cs
is excluded by!**/generated/**
src/libs/Instill/Generated/Instill.IAppClient.AppPublicServiceDeleteApp.g.cs
is excluded by!**/generated/**
src/libs/Instill/Generated/Instill.IAppClient.AppPublicServiceGetPlaygroundConversation.g.cs
is excluded by!**/generated/**
src/libs/Instill/Generated/Instill.IAppClient.AppPublicServiceListAgents.g.cs
is excluded by!**/generated/**
src/libs/Instill/Generated/Instill.IAppClient.AppPublicServiceListChats.g.cs
is excluded by!**/generated/**
src/libs/Instill/Generated/Instill.IAppClient.AppPublicServiceListTools.g.cs
is excluded by!**/generated/**
src/libs/Instill/Generated/Instill.IAppClient.AppPublicServiceRestartPlaygroundConversation.g.cs
is excluded by!**/generated/**
src/libs/Instill/Generated/Instill.IAppClient.AppPublicServiceUpdateAgent.g.cs
is excluded by!**/generated/**
src/libs/Instill/Generated/Instill.IAppClient.AppPublicServiceUpdateApp.g.cs
is excluded by!**/generated/**
src/libs/Instill/Generated/Instill.IAppClient.AppPublicServiceUpdateChat.g.cs
is excluded by!**/generated/**
src/libs/Instill/Generated/Instill.IAppClient.AppPublicServiceUpdateConversation.g.cs
is excluded by!**/generated/**
src/libs/Instill/Generated/Instill.Models.Agent.Json.g.cs
is excluded by!**/generated/**
src/libs/Instill/Generated/Instill.Models.Agent.g.cs
is excluded by!**/generated/**
src/libs/Instill/Generated/Instill.Models.AppPublicServiceCreateAgentResponse.Json.g.cs
is excluded by!**/generated/**
src/libs/Instill/Generated/Instill.Models.AppPublicServiceCreateAgentResponse.g.cs
is excluded by!**/generated/**
src/libs/Instill/Generated/Instill.Models.AppPublicServiceDeleteAgentResponse.Json.g.cs
is excluded by!**/generated/**
src/libs/Instill/Generated/Instill.Models.AppPublicServiceDeleteAgentResponse.g.cs
is excluded by!**/generated/**
src/libs/Instill/Generated/Instill.Models.AppPublicServiceListAgentsResponse.Json.g.cs
is excluded by!**/generated/**
src/libs/Instill/Generated/Instill.Models.AppPublicServiceListAgentsResponse.g.cs
is excluded by!**/generated/**
src/libs/Instill/Generated/Instill.Models.AppPublicServiceListToolsResponse.Json.g.cs
is excluded by!**/generated/**
src/libs/Instill/Generated/Instill.Models.AppPublicServiceListToolsResponse.g.cs
is excluded by!**/generated/**
src/libs/Instill/Generated/Instill.Models.AppPublicServiceUpdateAgentResponse.Json.g.cs
is excluded by!**/generated/**
src/libs/Instill/Generated/Instill.Models.AppPublicServiceUpdateAgentResponse.g.cs
is excluded by!**/generated/**
src/libs/Instill/Generated/Instill.Models.Chat.g.cs
is excluded by!**/generated/**
src/libs/Instill/Generated/Instill.Models.CreateAgentBody.Json.g.cs
is excluded by!**/generated/**
src/libs/Instill/Generated/Instill.Models.CreateAgentBody.g.cs
is excluded by!**/generated/**
src/libs/Instill/Generated/Instill.Models.CreateAgentResponse.Json.g.cs
is excluded by!**/generated/**
src/libs/Instill/Generated/Instill.Models.CreateAgentResponse.g.cs
is excluded by!**/generated/**
src/libs/Instill/Generated/Instill.Models.DeleteAgentResponse.Json.g.cs
is excluded by!**/generated/**
src/libs/Instill/Generated/Instill.Models.DeleteAgentResponse.g.cs
is excluded by!**/generated/**
src/libs/Instill/Generated/Instill.Models.ListAgentsResponse.Json.g.cs
is excluded by!**/generated/**
src/libs/Instill/Generated/Instill.Models.ListAgentsResponse.g.cs
is excluded by!**/generated/**
src/libs/Instill/Generated/Instill.Models.ListToolsResponse.Json.g.cs
is excluded by!**/generated/**
src/libs/Instill/Generated/Instill.Models.ListToolsResponse.g.cs
is excluded by!**/generated/**
src/libs/Instill/Generated/Instill.Models.Tool.g.cs
is excluded by!**/generated/**
src/libs/Instill/Generated/Instill.Models.ToolConfig.g.cs
is excluded by!**/generated/**
src/libs/Instill/Generated/Instill.Models.UpdateAgentBody.Json.g.cs
is excluded by!**/generated/**
src/libs/Instill/Generated/Instill.Models.UpdateAgentBody.g.cs
is excluded by!**/generated/**
src/libs/Instill/Generated/Instill.Models.UpdateAgentResponse.Json.g.cs
is excluded by!**/generated/**
src/libs/Instill/Generated/Instill.Models.UpdateAgentResponse.g.cs
is excluded by!**/generated/**
src/libs/Instill/Generated/Instill.Models.UpdateChatBody.g.cs
is excluded by!**/generated/**
src/libs/Instill/Generated/Instill.Models.UpdateConversationBody.g.cs
is excluded by!**/generated/**
src/libs/Instill/Generated/JsonSerializerContextTypes.g.cs
is excluded by!**/generated/**
📒 Files selected for processing (1)
src/libs/Instill/openapi.yaml
(15 hunks)
Summary by CodeRabbit