-
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat:Update OpenAPI specification to introduce AIAgentSettings schema #65
Conversation
WalkthroughThe changes in the OpenAPI specification for the Instill AI API include the introduction of a new schema called Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (1)
src/libs/Instill/openapi.yaml (1)
Line range hint
1-11033
: Clean transition from AIAgentAppMetadata to AIAgentSettingsThe API maintains backward compatibility while transitioning from AIAgentAppMetadata to AIAgentSettings. The v1alpha versioning is appropriately used to handle this schema evolution.
Consider adding deprecation notices in the AIAgentAppMetadata schema to guide users toward using the new AIAgentSettings schema in future versions.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
⛔ Files ignored due to path filters (17)
src/libs/Instill/Generated/Instill.AppClient.AppPublicServiceCreateAgent.g.cs
is excluded by!**/generated/**
src/libs/Instill/Generated/Instill.AppClient.AppPublicServiceCreateChat.g.cs
is excluded by!**/generated/**
src/libs/Instill/Generated/Instill.AppClient.AppPublicServiceUpdateAgent.g.cs
is excluded by!**/generated/**
src/libs/Instill/Generated/Instill.AppClient.AppPublicServiceUpdateChat.g.cs
is excluded by!**/generated/**
src/libs/Instill/Generated/Instill.IAppClient.AppPublicServiceCreateAgent.g.cs
is excluded by!**/generated/**
src/libs/Instill/Generated/Instill.IAppClient.AppPublicServiceCreateChat.g.cs
is excluded by!**/generated/**
src/libs/Instill/Generated/Instill.IAppClient.AppPublicServiceUpdateAgent.g.cs
is excluded by!**/generated/**
src/libs/Instill/Generated/Instill.IAppClient.AppPublicServiceUpdateChat.g.cs
is excluded by!**/generated/**
src/libs/Instill/Generated/Instill.Models.AIAgentSettings.Json.g.cs
is excluded by!**/generated/**
src/libs/Instill/Generated/Instill.Models.AIAgentSettings.g.cs
is excluded by!**/generated/**
src/libs/Instill/Generated/Instill.Models.AIAgentSettingsConnections.Json.g.cs
is excluded by!**/generated/**
src/libs/Instill/Generated/Instill.Models.AIAgentSettingsConnections.g.cs
is excluded by!**/generated/**
src/libs/Instill/Generated/Instill.Models.CreateAgentBody.g.cs
is excluded by!**/generated/**
src/libs/Instill/Generated/Instill.Models.CreateChatBody.g.cs
is excluded by!**/generated/**
src/libs/Instill/Generated/Instill.Models.UpdateAgentBody.g.cs
is excluded by!**/generated/**
src/libs/Instill/Generated/Instill.Models.UpdateChatBody.g.cs
is excluded by!**/generated/**
src/libs/Instill/Generated/JsonSerializerContextTypes.g.cs
is excluded by!**/generated/**
📒 Files selected for processing (1)
src/libs/Instill/openapi.yaml
(6 hunks)
🔇 Additional comments (2)
src/libs/Instill/openapi.yaml (2)
6269-6290
: Well-structured schema definition for AIAgentSettings
The new AIAgentSettings schema is cleanly implemented with proper typing and documentation for all fields. The schema effectively encapsulates the settings needed for AI agent configuration.
7205-7208
: Consistent integration of AIAgentSettings across request bodies
The AIAgentSettings schema has been consistently integrated into all relevant request bodies (CreateAgentBody, UpdateAgentBody, CreateChatBody, UpdateChatBody), maintaining a uniform approach to agent configuration.
Also applies to: 10647-10650, 7294-7297, 10727-10730
Summary by CodeRabbit
AIAgentSettings
, for enhanced configuration of AI agents.CreateAgentBody
,UpdateAgentBody
,CreateChatBody
, andUpdateChatBody
to utilize the newaiAgentSettings
schema, improving clarity in agent-related metadata management.