-
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat:Update OpenAPI specification for Jina Embedding Serving API endpoints and schemas #47
Conversation
WalkthroughThe changes involve modifications to the OpenAPI specification for the Jina Embedding Serving API. Key updates include the deprecation of the Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (3)
src/libs/Jina/openapi.yaml (3)
Line range hint
312-339
: Approve new/v1/multi-vector
endpoint with a suggestion for clarity.The addition of the
/v1/multi-vector
endpoint is a good improvement, providing functionality to create multiple vector representations of input texts. This appears to be a replacement for the deprecated/v1/multi-embeddings
endpoint.To improve clarity, consider adding a brief explanation of how this differs from the standard embedding endpoint. For example, you could add:
"Unlike the standard embedding endpoint, this endpoint creates a separate vector for each token in the input text, which can be useful for certain advanced retrieval techniques."
Line range hint
340-367
: Enhance deprecation notice for/v1/multi-embeddings
endpoint.The
/v1/multi-embeddings
endpoint has been correctly marked as deprecated. To further assist API users, consider adding migration information to the description. For example:description: | Create multiple vector representations of the given input texts. One vector representation for each token in the input text. DEPRECATED: This endpoint is deprecated and will be removed in a future version. Please use the `/v1/multi-vector` endpoint instead.This addition will help guide users towards the new endpoint and ensure a smoother transition.
Line range hint
376-380
: Approve addition ofThe addition of the
Body_start_bulk_embedding_v1_bulk_embeddings_post
schema is approved. This allows for associating the bulk embedding job with a specific user email.For consistency, consider renaming this property to
user_email
to match the corresponding field in theBulkEmbeddingJobResponse
schema. This would make the API more intuitive and easier to understand.Also, ensure that the same privacy considerations mentioned for the
user_email
in the response are applied here as well.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
⛔ Files ignored due to path filters (7)
src/libs/Jina/Generated/Jina.Models.ApiSchemasClassificationImageDoc.g.cs
is excluded by!**/generated/**
src/libs/Jina/Generated/Jina.Models.ApiSchemasClassificationTextDoc.g.cs
is excluded by!**/generated/**
src/libs/Jina/Generated/Jina.Models.ApiSchemasEmbeddingImageDoc.g.cs
is excluded by!**/generated/**
src/libs/Jina/Generated/Jina.Models.ApiSchemasEmbeddingTextDoc.g.cs
is excluded by!**/generated/**
src/libs/Jina/Generated/Jina.Models.ApiSchemasRankTextDoc.g.cs
is excluded by!**/generated/**
src/libs/Jina/Generated/Jina.Models.ImageExampleDoc.g.cs
is excluded by!**/generated/**
src/libs/Jina/Generated/Jina.Models.TextExampleDoc.g.cs
is excluded by!**/generated/**
📒 Files selected for processing (1)
- src/libs/Jina/openapi.yaml (7 hunks)
🧰 Additional context used
🔇 Additional comments (6)
src/libs/Jina/openapi.yaml (6)
581-581
: Update example ID to use a more realistic format.The example ID for the
ImageExampleDoc
schema has been updated to use a more realistic format. This change improves the clarity of the documentation.
948-948
: Update example ID to use a more realistic format.Similar to the
ImageExampleDoc
, the example ID for theTextExampleDoc
schema has been updated to use a more realistic format. This change maintains consistency across the documentation.
1066-1066
: Consistent update of example IDs across multiple schemas.The example IDs for various schemas (
api_schemas__classification__ImageDoc
,api_schemas__classification__TextDoc
,api_schemas__embedding__ImageDoc
,api_schemas__embedding__TextDoc
, andapi_schemas__rank__TextDoc
) have all been updated to use the same realistic format. This change ensures consistency across the API documentation and improves readability.Also applies to: 1100-1100, 1128-1128, 1162-1162, 1192-1192
Line range hint
106-110
: Approve addition ofuser_email
with privacy consideration.The addition of the
user_email
property to theBulkEmbeddingJobResponse
schema is approved. This can be useful for tracking and notification purposes.However, please ensure that appropriate measures are in place to protect user privacy:
- Confirm that the email is only returned to authenticated users with the appropriate permissions.
- Consider whether this field should be optional, depending on user privacy settings.
- Ensure compliance with relevant data protection regulations (e.g., GDPR) when storing and transmitting this information.
581-581
: Approve consistent update of example IDs across schemas.The update of example IDs to use a more realistic format (MD5-like hash) across multiple schemas is approved. This change improves the consistency and realism of the API documentation, making it easier for developers to understand the expected format of IDs.
The affected schemas include:
ImageExampleDoc
TextExampleDoc
api_schemas__classification__ImageDoc
api_schemas__classification__TextDoc
api_schemas__embedding__ImageDoc
api_schemas__embedding__TextDoc
api_schemas__rank__TextDoc
This consistent approach enhances the overall quality of the API specification.
Also applies to: 948-948, 1066-1066, 1100-1100, 1128-1128, 1162-1162, 1192-1192
Line range hint
1-1228
: Overall approval with minor suggestions for improvement.The changes to the OpenAPI specification for the Jina Embedding Serving API are generally well-implemented and enhance the API's functionality and documentation. Key improvements include:
- Addition of the new
/v1/multi-vector
endpoint.- Deprecation of the
/v1/multi-embeddings
endpoint.- Updates to various schemas to include new properties like
user_email
.- Consistent update of example IDs across multiple schemas.
These changes should improve the API's usability and provide better support for advanced embedding techniques. To further enhance the specification:
- Consider adding more detailed migration guidance for the deprecated endpoint.
- Ensure consistency in naming conventions (e.g.,
user_email
).- Review and update the security and privacy considerations for new user-related fields.
Overall, these changes represent a positive evolution of the API specification.
Summary by CodeRabbit
New Features
/v1/multi-vector
)./v1/train
endpoint description for better clarity.Improvements
Deprecations
/v1/multi-embeddings
endpoint as deprecated.