-
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat:Update OpenAPI Specification for Jina Embedding Serving API to 0.1.76 #58
Conversation
WalkthroughThe pull request introduces significant updates to the OpenAPI specification of the Jina Embedding Serving API, incrementing the version to 0.1.76 and aligning with OpenAPI 3.0.1 standards. Key modifications include the deprecation of the Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (3)
src/libs/Jina/openapi.yaml (3)
Line range hint
232-262
: Excellent addition of the/v1/multi-vector
endpoint.The new
/v1/multi-vector
endpoint enhances the API's capabilities by providing multiple vector representations for each token in the input text. This is a valuable feature for more granular text embedding tasks.Consider updating the API documentation to highlight this new feature and provide usage examples for developers.
Line range hint
263-293
: Appropriate deprecation of the/v1/multi-embeddings
endpoint.Marking the
/v1/multi-embeddings
endpoint as deprecated is a good practice for API evolution. This aligns with the introduction of the new/v1/multi-vector
endpoint.Consider adding a migration guide in the API documentation to help users transition from the deprecated
/v1/multi-embeddings
to the new/v1/multi-vector
endpoint.
Line range hint
1-1226
: Well-structured API evolution with new features and proper deprecation.The changes to the OpenAPI specification are well-implemented, maintaining backwards compatibility while introducing new features. Key points:
- The API version has been updated to 0.1.76.
- A new
/v1/multi-vector
endpoint has been added, enhancing the API's capabilities.- The
/v1/multi-embeddings
endpoint has been properly deprecated.- Example IDs have been consistently updated throughout the file.
- The overall structure and functionality of the API remain stable.
These changes demonstrate good API design practices, allowing for evolution while minimizing disruption to existing users.
As the API continues to evolve, consider the following:
- Implement versioning in the URL (e.g.,
/v2/
) for major changes in the future.- Provide a changelog in the API documentation to help users track changes across versions.
- Consider setting up an API deprecation policy to communicate how long deprecated endpoints will be supported.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
⛔ Files ignored due to path filters (7)
src/libs/Jina/Generated/Jina.Models.ApiSchemasClassificationImageDoc.g.cs
is excluded by!**/generated/**
src/libs/Jina/Generated/Jina.Models.ApiSchemasClassificationTextDoc.g.cs
is excluded by!**/generated/**
src/libs/Jina/Generated/Jina.Models.ApiSchemasEmbeddingImageDoc.g.cs
is excluded by!**/generated/**
src/libs/Jina/Generated/Jina.Models.ApiSchemasEmbeddingTextDoc.g.cs
is excluded by!**/generated/**
src/libs/Jina/Generated/Jina.Models.ApiSchemasRankTextDoc.g.cs
is excluded by!**/generated/**
src/libs/Jina/Generated/Jina.Models.ImageExampleDoc.g.cs
is excluded by!**/generated/**
src/libs/Jina/Generated/Jina.Models.TextExampleDoc.g.cs
is excluded by!**/generated/**
📒 Files selected for processing (1)
- src/libs/Jina/openapi.yaml (7 hunks)
🧰 Additional context used
🔇 Additional comments (2)
src/libs/Jina/openapi.yaml (2)
Line range hint
1-7
: LGTM: Version update and general information.The OpenAPI specification has been updated to version 0.1.76. The general information and server configuration look good.
581-581
: Consistent update of example IDs.The example IDs have been updated throughout the file to '638c3de241576a03c6d4226261d8e11a'. This change ensures consistency across the documentation.
To ensure all occurrences have been updated, please run the following command:
This will list all lines containing the new example ID, allowing you to verify that the update has been applied consistently throughout the file.
Also applies to: 948-948, 1066-1066, 1100-1100, 1128-1128, 1162-1162, 1192-1192
✅ Verification successful
Example ID Update Verified
All occurrences of the new example ID
638c3de241576a03c6d4226261d8e11a
have been successfully updated in the following lines ofsrc/libs/Jina/openapi.yaml
:
- 581
- 948
- 1066
- 1100
- 1128
- 1162
- 1192
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Verify all occurrences of the new example ID grep -n "638c3de241576a03c6d4226261d8e11a" src/libs/Jina/openapi.yamlLength of output: 466
Summary by CodeRabbit
New Features
POST /v1/multi-vector
for creating multiple vector representations of input texts.Deprecations
POST /v1/multi-embeddings
endpoint as deprecated.Documentation Improvements