-
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat:Update OpenAPI specification for Jina Embedding Serving API to 0.1.79 #61
Conversation
WalkthroughThe OpenAPI specification for the Jina Embedding Serving API has been updated from version 0.1.76 to 0.1.79. This update introduces new endpoints for listing and deleting classifiers, modifies the Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (1)
src/libs/Jina/openapi.yaml (1)
201-215
: New GET endpoint for listing classifiers added.The new endpoint
/v1/classifiers
has been correctly implemented with appropriate tags and security requirements. However, the response schema is empty, which might not be informative for API consumers.Consider adding a more detailed response schema that includes the structure of the classifier information to be returned.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
⛔ Files ignored due to path filters (14)
src/libs/Jina/Generated/Jina.ClassificationClient.DeleteClassifier.g.cs
is excluded by!**/generated/**
src/libs/Jina/Generated/Jina.ClassificationClient.ListClassifier.g.cs
is excluded by!**/generated/**
src/libs/Jina/Generated/Jina.ClassificationClient.Train.g.cs
is excluded by!**/generated/**
src/libs/Jina/Generated/Jina.IClassificationClient.DeleteClassifier.g.cs
is excluded by!**/generated/**
src/libs/Jina/Generated/Jina.IClassificationClient.ListClassifier.g.cs
is excluded by!**/generated/**
src/libs/Jina/Generated/Jina.IClassificationClient.Train.g.cs
is excluded by!**/generated/**
src/libs/Jina/Generated/Jina.Models.DeleteClassifierV1ClassifiersClassifierIdDeleteResponse.g.cs
is excluded by!**/generated/**
src/libs/Jina/Generated/Jina.Models.ListClassifierV1ClassifiersGetResponse.g.cs
is excluded by!**/generated/**
src/libs/Jina/Generated/Jina.Models.TrainingAPIInput.g.cs
is excluded by!**/generated/**
src/libs/Jina/Generated/Jina.Models.TrainingAPIInputAccess.g.cs
is excluded by!**/generated/**
src/libs/Jina/Generated/JsonConverters.TrainingAPIInputAccess.g.cs
is excluded by!**/generated/**
src/libs/Jina/Generated/JsonConverters.TrainingAPIInputAccessNullable.g.cs
is excluded by!**/generated/**
src/libs/Jina/Generated/JsonSerializerContext.g.cs
is excluded by!**/generated/**
src/libs/Jina/Generated/JsonSerializerContextTypes.g.cs
is excluded by!**/generated/**
📒 Files selected for processing (1)
- src/libs/Jina/openapi.yaml (4 hunks)
🧰 Additional context used
🔇 Additional comments (3)
src/libs/Jina/openapi.yaml (3)
5-5
: API version updated correctly.The API version has been incremented from 0.1.76 to 0.1.79, which is consistent with the changes described in the summary.
216-243
: New DELETE endpoint for removing classifiers added.The new endpoint
/v1/classifiers/{classifier_id}
has been correctly implemented with appropriate tags, parameters, and security requirements. The addition of this endpoint enhances the API's functionality for classifier management.
1016-1022
: TrainingAPIInput schema updated correctly.The
visibility
field has been appropriately renamed toaccess
in the TrainingAPIInput schema. The change is consistent in both the schema definition and the example provided. This modification improves clarity in describing the accessibility of the classifier.Also applies to: 1044-1044
Summary by CodeRabbit
New Features
Improvements
TrainingAPIInput
schema: renamedvisibility
toaccess
with unchanged enum values.Version Update