-
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat:Update OpenAPI Specification for Jina Embedding Serving API to v0.1.89 #74
Conversation
WalkthroughThe pull request includes updates to the OpenAPI specification for the Jina Embedding Serving API. The version has been incremented from Changes
Sequence Diagram(s)sequenceDiagram
participant Client
participant API
participant Auth
Client->>Auth: Request Bearer Token
Auth-->>Client: Return Bearer Token
Client->>API: Call /v1/embeddings with Token
API-->>Client: Return Embedding Response
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (1)
src/libs/Jina/openapi.yaml (1)
Line range hint
32-38
: Add migration guidance for deprecated endpoint.While the
/v1/multi-embeddings
endpoint is correctly marked as deprecated, it would be helpful to add migration guidance in the description to help users transition to the/v1/multi-vector
endpoint.description: Create multiple vector representations of the given input texts. One vector representation for each token in the input text. + description: | + DEPRECATED: This endpoint is deprecated and will be removed in a future version. + Please migrate to the `/v1/multi-vector` endpoint which provides identical functionality. + + Create multiple vector representations of the given input texts. One vector representation for each token in the input text.Also applies to: 279-321
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (1)
src/libs/Jina/openapi.yaml
(1 hunks)
🔇 Additional comments (3)
src/libs/Jina/openapi.yaml (3)
5-5
: LGTM: Version increment is appropriate.
The version has been correctly incremented from 0.1.87 to 0.1.89.
Line range hint 322-1037
: LGTM: Well-structured schema definitions.
The schema definitions are comprehensive and follow OpenAPI best practices:
- Proper validation rules are in place
- Detailed model descriptions with parameter sizes and dimensions
- Clear input/output schemas with examples
Line range hint 1038-1042
: LGTM: Proper security implementation.
The API consistently implements HTTP Bearer authentication across all endpoints, following security best practices.
Summary by CodeRabbit
/v1/multi-embeddings
endpoint to signal a design shift.0.1.87
to0.1.89
.