-
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat:Update OpenAPI specification for Jina Embedding Serving API to 0.1.94 #82
Conversation
WalkthroughThe changes involve an update to the OpenAPI specification for the Jina Embedding Serving API, specifically updating the version from Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (1)
src/libs/Jina/openapi.yaml (1)
617-617
: Enhancement: Improved default behavior and task specification in ImageEmbeddingInputGood improvements:
- Setting
normalized: true
as default aligns with common use cases where normalized embeddings are preferred- The addition of the
task
property with specific enum values helps optimize embedding generation for different downstream applicationsConsider documenting the performance characteristics and trade-offs for each task type in the model's technical documentation to help users make informed decisions.
Also applies to: 618-628
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
⛔ Files ignored due to path filters (2)
src/libs/Jina/Generated/Jina.Models.ImageEmbeddingInput.g.cs
is excluded by!**/generated/**
src/libs/Jina/Generated/Jina.Models.MixedEmbeddingInput.g.cs
is excluded by!**/generated/**
📒 Files selected for processing (1)
src/libs/Jina/openapi.yaml
(3 hunks)
🔇 Additional comments (2)
src/libs/Jina/openapi.yaml (2)
5-5
: LGTM: Version increment follows semantic versioning
The patch version increment from 0.1.93 to 0.1.94 correctly reflects backward-compatible changes.
718-718
: Enhancement: Consistent schema updates in MixedEmbeddingInput
Good improvements that maintain consistency with ImageEmbeddingInput:
- Same default normalization behavior
- Same task property with identical enum values
Let's verify the consistency of these changes across the codebase:
Also applies to: 719-729
Summary by CodeRabbit
New Features
task
property in embedding input schemas for better application targeting.normalized
property to default totrue
in embedding input schemas for automatic normalization of embeddings.Bug Fixes