Fix browser errors about async responses #304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes #303 The issue was that the deferred listener abstraction would `return true` (telling the browser to expect an async response) for every message, even if the messages were not from the library. In `wrapStore()`, those messages would be ignored causing the browser to log an error: Error: A listener indicated an asynchronous response by returning true, but the message channel closed before a response was received This is mostly harmless, but it's better to avoid the error. In this commit, `createDeferredListener()` now takes a `filter` function that determines if the message will be handled so that messages from outside the library can be ignored. This requires a breaking change: moving the `channelName` argument to `createWrapStore()`. This is required since the filter function needs to know which channel to expect before `wrapStore()` is called.
Lalg28
approved these changes
Sep 24, 2024
SentientClee
approved these changes
Oct 1, 2024
SidneyNemzer
force-pushed
the
async-response
branch
from
5d53292 to
37735a3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #303
The issue was the deferred listener helper would
return true(telling the browser to expect an async response) for every message, even if the messages were not from the library. InwrapStore(), those messages would be ignored causing the browser to log an error:This is mostly harmless, but it's better to avoid the error. In this commit,
createDeferredListener()now takes afilterfunction that determines if the message will be handled so that messages from outside the library can be ignored.Unfortunately this requires a breaking change: moving the
channelNameargument tocreateWrapStore(). This is required since the filter function needs to know which channel to expect beforewrapStore()is called. I'm hoping that most consumers don't passchannelNameso this won't affect most apps.