code restructure to enable package install #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
savitakartik
force-pushed
the
restructure_as_package
branch
from
0b57d75
to
390ba9a
Compare
setup.cfg
Outdated
| datashader | ||
| tskit | ||
| seaborn | ||
| pre-commit |
There was a problem hiding this comment.
Install doesn't need pre-commit
tsqc/__main__.py
Outdated
| @@ -50,7 +49,7 @@ def show(page): | |||
| yield pn.indicators.LoadingSpinner(value=True, width=50, height=50) | |||
| try: | |||
| before = time.time() | |||
| content = page_map[page](tsm) | |||
| content = page_map[page].page(tsm) | |||
There was a problem hiding this comment.
maybe change to page_map[page_name]? Too many "page"s!
fixes tskit-dev#91 removed keyword to IntSlider that was causing test_pages to fail with Panel v1.18.1 renamed variables in __main__.py, addressed logging FIXME in __main__.py, updated instructions to run in README
savitakartik
force-pushed
the
restructure_as_package
branch
from
390ba9a
to
cc69203
Compare
jeromekelleher
approved these changes
Jan 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #91