Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

first implementation of annotation track #131

Merged
merged 1 commit into from
Mar 7, 2024

Conversation

savitakartik
Copy link
Collaborator

@savitakartik savitakartik commented Mar 6, 2024

adds a basic gene track to the Mutations page when a gene coordinate csv like below is provided
python -m tsqc path/to/trees --annotate-genes path/to/csv
image

Few issues to iron out:

input annotation file format checks. (I guess it might be better to switch to a standard bed or gtf format file at some point.)
subset annotation data to the same chromosome as tree sequence
restrict y zooming on the genome and tree tracks

@savitakartik
Copy link
Collaborator Author

gene_annotation.mp4

@savitakartik
Copy link
Collaborator Author

savitakartik commented Mar 6, 2024

Is it ok to update file path in the config file like I've done in main?

if annotate_genes:
        config.GENES_FILE = annotate_genes

or should user directly just provide a path in the config file?

@savitakartik savitakartik force-pushed the gene_track branch 2 times, most recently from dc44ee9 to acb47c6 Compare March 7, 2024 09:47
Copy link
Member

@jeromekelleher jeromekelleher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Putting the annotations_file in a global config is a bit icky, but it works for now and I can imagine that being something you just want to set as a default (in your .config/tsqc.conf file, at some point).

tsqc/pages/mutations.py Outdated Show resolved Hide resolved
tsqc/__main__.py Outdated Show resolved Hide resolved
@jeromekelleher
Copy link
Member

Few minor changes, let's merge then

@savitakartik
Copy link
Collaborator Author

LGTM! Putting the annotations_file in a global config is a bit icky, but it works for now and I can imagine that being something you just want to set as a default (in your .config/tsqc.conf file, at some point).

sure, that makes sense.

@savitakartik savitakartik marked this pull request as ready for review March 7, 2024 10:09
@jeromekelleher jeromekelleher merged commit 26d3ee9 into tskit-dev:main Mar 7, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants