Fix initially blank mutations

[benjeffery]

@savitakartik The page seems to still work without filtering the points in the datashade, which was causing them all to get filtered initially. Do you know if it was needed?

[coveralls]

Pull Request Test Coverage Report for Build 11180038052

Details

• 3 of 3 (100.0%) changed or added relevant lines in 2 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage increased (+0.2%) to 83.172%

---

Totals
Change from base Build 11179721596:	0.2%
Covered Lines:	771
Relevant Lines:	927

---

💛 - Coveralls

[savitakartik]

The filter was being used because we only wanted hover tool tips to be displayed if there were less than a certain number of points in the viewport.

[savitakartik]

Hmm, interesting. I'm seeing a blank mutations panel with or without the filter. I'll check again and share some screenshots tomorrow.

[savitakartik]

Here's what I see when I try this PR on simulated trees. I still have the initial blank screen problem with all datashaded/filtered plots (Mutations, Nodes and Edges). But when I refresh the plot, the problem persists only in Mutations. Same as what I was seeing before. I'll open issues.

fix-blank-muts-branch_mutations_panel.mp4

[benjeffery]

Note that this PR only changes mutations - here's the same on my machine:

Peek.2024-09-27.11-35.mp4

What versions are you running? I'm:

panel==1.4.5
bokeh==3.4.3
holoviews==1.19.1

[savitakartik]

Note that this PR only changes mutations - here's the same on my machine:

Peek.2024-09-27.11-35.mp4
What versions are you running? I'm:

panel==1.4.5
bokeh==3.4.3
holoviews==1.19.1

Thanks, Ben. I'm running the same versions of these packages as you are!

Great, so it looks like this fix could be applied to Nodes and Edges too, which also use filtering. I was just trying to diagnose the issue with Mutations as I can't see that plot at all! It looks like that's a separate issue only on my machine. Would you mind sharing a clip with hover in the initial plot, and then after zooming in till the points are coloured by number of inheritors? The intention with the filter/hover functions was to overlay a colour-by plot of the actual data points and activate hover only when zoomed in to a certain level. I'm not able to verify that that still works! I suppose one option would be to scrap that feature entirely.

[jeromekelleher]

How do we view the uploaded artefacts @benjeffery?

[github-actions]

Automated Screenshots

These screenshots are automatically updated as the PR changes.

Click to view screenshots

out_edges.png

out_mutations.png

out_nodes.png

[benjeffery]

How do we view the uploaded artefacts @benjeffery?

They should be viewable here: #177 (comment)

[jeromekelleher]

Amazing!