Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Order columns in table view #193

Merged
merged 2 commits into from
Oct 14, 2024
Merged

Conversation

benjeffery
Copy link
Member

@benjeffery benjeffery commented Oct 11, 2024

Fixes #189
Fixes #191
Fixes #192

@coveralls
Copy link

coveralls commented Oct 11, 2024

Pull Request Test Coverage Report for Build 11329376814

Details

  • 1 of 2 (50.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.08%) to 82.225%

Changes Missing Coverage Covered Lines Changed/Added Lines %
tsbrowse/pages/tables.py 1 2 50.0%
Totals Coverage Status
Change from base Build 11295259881: -0.08%
Covered Lines: 680
Relevant Lines: 827

💛 - Coveralls

Copy link

Automated Screenshots

These screenshots are automatically updated as the PR changes.

Click to view screenshots

out_edges.png

out_edges.png

out_mutations.png

out_mutations.png

out_nodes.png

out_nodes.png

github-actions bot pushed a commit that referenced this pull request Oct 11, 2024
Copy link
Member

@jeromekelleher jeromekelleher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

"time",
"position",
"num_parents",
"num_descendants",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we want num_inheritors too, assuming we calculate this here

github-actions bot pushed a commit that referenced this pull request Oct 14, 2024
@benjeffery benjeffery merged commit 623dc2e into tskit-dev:main Oct 14, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

KeyError: 'log_time' in table viewer column order in table viewer redundant columns in table viewer
3 participants