Add loading indicator and error handling to pages #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benjeffery
changed the title
|
What do you think @savitakartik ? |
|
Looks good to me. I love both features. A really minor thing I find with the loading indicator is that it doesn't show up for the very first page you click on. Works fine every other time. The error display is also really nice, makes it really easy to debug. Thanks so much, @benjeffery ! |
|
I'm not sure I understand why the linting check failed though. Seems like formatting changes, so not sure why they didn't get automatically fixed? |
My bad, didn't install pre-commit locally! |
savitakartik
approved these changes
Aug 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a spinner to indicate that the page is being prepared, and display an error with stacktrace if the page code errors.
