Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable bokeh toolbar #73

Merged
merged 1 commit into from
Sep 1, 2023

Conversation

savitakartik
Copy link
Collaborator

@savitakartik savitakartik commented Aug 30, 2023

Fixes issue #69

Changed all histograms to bokeh
Moved hist function to plot_helpers

Will delete the matplotlib plots in the Trees page if we decide to go with bokeh throughout.

@savitakartik savitakartik changed the title Changed histograms to bokeh. Moved hist function to plot_helpers Disable bokeh toolbar Aug 30, 2023
@savitakartik savitakartik marked this pull request as ready for review August 30, 2023 17:11
@jeromekelleher
Copy link
Member

Looks great, lets go Bokeh all the way.

Copy link
Member

@benjeffery benjeffery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@savitakartik
Copy link
Collaborator Author

Just deleted the matplotlib page and cleaned up code. I think this is ready to merge.

@jeromekelleher jeromekelleher merged commit 7909ee3 into tskit-dev:main Sep 1, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants