-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rejig main entry point #87
Conversation
Looks great! |
I had 2 questions related to this PR:
|
Thanks for taking a look @savitakartik, this is very helpful. We'll need to fix/document the behaviour in WSL. I've added #89 to track adding tests for compressed input There should already be a help interface:
it's pretty basic, but we can fill it out as we go. Does this work for you? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Seems to remove the ability to use --dev
as I can't see any option on panel.serve
which does that, but I can live with that.
Ah, must have missed it, totally works for me! |
Change how we run tsqc from using
panel serve
topython3 main.py
. This is a step towards packaging everything up in a more standard way, where we ship this as a Python package.Also clarifies the logic of when we load up the datafile and how we cache it, which was quite confusing before.
Also supports tszip input.
Closes #82