Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First draft of a simplification tute. #188

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

gtsambos
Copy link
Member

Not yet finished, but will close #52 when it is. Just making this PR now so that people can look and comment.

@gtsambos gtsambos marked this pull request as draft July 20, 2022 13:21
@hyanwong
Copy link
Member

Who putting together my ARG poster (https://docs.google.com/presentation/d/1_IcShje2CFbEPbUzodNkgNBv2m37xGx32np_YK7LvfE), I realised that there's a difference between the sort of "simplification" that keeps all nodes present but simply changes edge intervals (i.e. converting a "direct inheritance" graph into a "sample resolved inheritance" graph, and the sort of simplification that we normally mean in tskit, in which non-ancestral nodes are dropped (and potentially, ancestral unary nodes of various sorts are dropped too.

I wonder if we should have a separate word for the first thing, with the assumption that the first stage of running "true" simplification is to ensure that the edges are sample resolved, so that you can identify which nodes can be dropped, etc?

@hyanwong
Copy link
Member

hyanwong commented Jun 20, 2023

Sorry not to have merged this yet @gtsambos - I thought maybe it was worth waiting until @GertjanBisschop had finished thinking about the logical arrangement of the simplify flags.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tutorial: simplify
2 participants