Suggested edits #279
Closed
Suggested edits #279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM - needs a sqash and rebase before merge as the commit list has a merge commit in. |
|
@benjeffery I always struggle with |
The workflow docs are here: I can fix up this PR if you like? |
|
Also for "when rebasing goes wrong" see: https://popsim-consortium.github.io/stdpopsim-docs/stable/development.html#when-rebasing-goes-wrong |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Passed terminology_and_concepts.md and thought these edits might be useful.
My plan is to go over some/most of the tuts. Should I suggest edits one at a time or in a batch?