refactor: form to json review #163
Conversation
| plans, _, err := apiClient.ServiceApi.ServicePlans(context.Background(), serviceName, &tsuru.ServicePlansOpts{ | ||
| Pool: optional.NewString(c.pool), | ||
| }) | ||
| plans, _, err := apiClient.ServiceApi.ServicePlans(context.Background(), serviceName, &tsuru.ServicePlansOpts{Pool: optional.NewString(c.pool)}) |
There was a problem hiding this comment.
@CarlosRoGuerra do you prefer one line instead of break lines ?
There was a problem hiding this comment.
I prefer it with break line, I think when correcting some things I must have left it that way accidentally
…pdate in volume.go and changePassword in auth.go
| return errors.New("User creation is disabled.") | ||
| } | ||
| userData := c.userData(ctx, password) | ||
| response, err := apiClient.UserApi.UserCreate(context.TODO(), userData) |
There was a problem hiding this comment.
you should remove context.TODO()
| userData := c.userData(ctx, password) | ||
| response, err := apiClient.UserApi.UserCreate(context.TODO(), userData) | ||
| if err != nil { | ||
| return err |
There was a problem hiding this comment.
why did you remove the "method not allowed" check?
tsuru/client/auth.go
Outdated
| if err != nil { | ||
| return err | ||
| } | ||
| request.Header.Set("Content-Type", "application/x-www-form-urlencoded") | ||
| _, err = client.Do(request) | ||
| changePassword := c.ChangePassword(old, new, confirm) |
There was a problem hiding this comment.
this variable name does not make any sense... changePassword->changedPassword or changePassword->newPassword
Codecov Report
@@ Coverage Diff @@
## master #163 +/- ##
==========================================
+ Coverage 66.29% 66.94% +0.65%
==========================================
Files 48 48
Lines 9011 8962 -49
==========================================
+ Hits 5974 6000 +26
+ Misses 2116 2077 -39
+ Partials 921 885 -36
Continue to review full report at Codecov.
|
CarlosRoGuerra
changed the title
CarlosRoGuerra
force-pushed
the
master
branch
from
c7fe320 to
8d5a611
Compare
CarlosRoGuerra
force-pushed
the
refactor-json
branch
from
21736d5 to
811c43b
Compare
Commands: