-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add additional models to provider JSON #331
Conversation
providers/AVISO.json
Outdated
@@ -123,6 +123,83 @@ | |||
} | |||
}, | |||
"elevation": { | |||
"FES2012": { | |||
"format": "FES-netcdf", | |||
"constituents": [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is specifying constituents
necessary, or will pyTMD auto-guess the constituent names? (previously, I had simply used "model_file": "fes2012/data/*_FES2012_SLEV.nc"
, but that wasn't being recognised here)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right, the glob string capability isn't being run for the database as I figured the database will be more "maintained".
"m8", | ||
"nu2" | ||
], | ||
"model_file": [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The one file I couldn't find a match for was Z0_FES2012_SLEV.nc
- have left it out here for now
"fes2012/data/MS4_FES2012_SLEV.nc", | ||
"fes2012/data/R2_FES2012_SLEV.nc", | ||
"fes2012/data/Mu2_FES2012_SLEV.nc", | ||
"fes2012/data/E2_FES2012_SLEV.nc", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is E2
a match for eps2
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I removed the constituents from the database and am running the files through the parser as before. Should make maintenance easier :)
"fes2012/data/E2_FES2012_SLEV.nc", | ||
"fes2012/data/S4_FES2012_SLEV.nc", | ||
"fes2012/data/Ssa_FES2012_SLEV.nc", | ||
"fes2012/data/La2_FES2012_SLEV.nc", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is La2
a match for l2
? Or lambda2
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lambda2
"TPXO8-atlas-nc": { | ||
"format": "ATLAS-netcdf", | ||
"name": "TPXO8-atlas-nc", | ||
"model_file": [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Had previous used "model_file": "TPXO8_atlas_v1/hf.*_tpxo8_atlas_30c_v1.nc"
, so have attempted to adapt this to a list of model files
Code used to test:
|
drop constituents from database
thanks @robbibt! Want to add yourself to the list of contributors? |
ef379d8
to
26fdd5f
Compare
@tsutterley I've added the following new models to the relevant provider JSON files:
Have tested these locally and they seem to work:
However, I did find that my model definitions that use wildcard matching (e.g.
"model_file": "TPXO8_atlas_v1/hf.*_tpxo8_atlas_30c_v1.nc"
) didn't recognise files in this new implementation, so I had to manually create the model file and constituent lists. I'm not experienced with this stuff so it would be great if you could double-check my changes and make sure I have specified them correctly/matched the right files to the right constituents!