Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: j1 and theta for FES type models #336

Merged
merged 2 commits into from
Sep 10, 2024
Merged

fix: j1 and theta for FES type models #336

merged 2 commits into from
Sep 10, 2024

Conversation

tsutterley
Copy link
Owner

fix: nodal corrections for eps2 and eta2 when inferring for GOT5.5

fix: nodal corrections for `eps2` and `eta2` when inferring for GOT5.5
Copy link

codecov bot commented Sep 10, 2024

Codecov Report

Attention: Patch coverage is 34.17722% with 52 lines in your changes missing coverage. Please review.

Project coverage is 72.53%. Comparing base (bd3d702) to head (d173d35).
Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
pyTMD/arguments.py 19.35% 49 Missing and 1 partial ⚠️
pyTMD/io/model.py 85.71% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #336      +/-   ##
==========================================
+ Coverage   71.65%   72.53%   +0.88%     
==========================================
  Files          39       39              
  Lines       11042    10268     -774     
  Branches     1522     1368     -154     
==========================================
- Hits         7912     7448     -464     
+ Misses       2632     2356     -276     
+ Partials      498      464      -34     
Flag Coverage Δ
unittests 72.53% <34.17%> (+0.88%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

feat: add option to select nodal corrections type (expose option)
@tsutterley tsutterley self-assigned this Sep 10, 2024
@tsutterley tsutterley added the bug label Sep 10, 2024
@tsutterley tsutterley merged commit 1a9bee3 into main Sep 10, 2024
4 of 5 checks passed
@tsutterley tsutterley deleted the dev branch September 10, 2024 04:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Differences in modelled FES elevations between pyTMD=2.1.4 and pyTMD==2.1.5
1 participant