Release v2.6.1

tswaters · May 27, 2021 · 6b31900 · 6b31900
1 parent 2824d67
commit 6b31900
Show file tree

Hide file tree

Showing 11 changed files with 193 additions and 169 deletions.
diff --git a/CHANGES.MD b/CHANGES.MD
@@ -1,3 +1,7 @@
+## 2.6.1
+
+- Make start idempotent (#16)
+
 ## 2.6.0
 
 - Adding cannons option

diff --git a/fireworks.js b/fireworks.js
@@ -225,10 +225,10 @@
         };
         Fireworks.prototype.start = function () {
             var _this = this;
-            if (this.maxRockets > 0) {
-                this.interval = window.setInterval(function () { return _this.things.spawnRockets(); }, this.rocketSpawnInterval);
-                this.rafInterval = window.requestAnimationFrame(function () { return _this.update(); });
-            }
+            if (this.interval != null)
+                return;
+            this.interval = window.setInterval(function () { return _this.things.spawnRockets(); }, this.rocketSpawnInterval);
+            this.rafInterval = window.requestAnimationFrame(function () { return _this.update(); });
             return function () { return _this.stop(); };
         };
         Fireworks.prototype.updateDimensions = function () {

diff --git a/fireworks.js.map b/fireworks.js.map
diff --git a/fireworks.min.js b/fireworks.min.js
diff --git a/fireworks.min.js.map b/fireworks.min.js.map
diff --git a/fireworks.mjs b/fireworks.mjs
@@ -175,10 +175,10 @@ class Fireworks {
         window.cancelAnimationFrame(this.rafInterval);
     }
     start() {
-        if (this.maxRockets > 0) {
-            this.interval = window.setInterval(() => this.things.spawnRockets(), this.rocketSpawnInterval);
-            this.rafInterval = window.requestAnimationFrame(() => this.update());
-        }
+        if (this.interval != null)
+            return;
+        this.interval = window.setInterval(() => this.things.spawnRockets(), this.rocketSpawnInterval);
+        this.rafInterval = window.requestAnimationFrame(() => this.update());
         return () => this.stop();
     }
     updateDimensions() {

diff --git a/fireworks.mjs.map b/fireworks.mjs.map
diff --git a/fireworks.node.js b/fireworks.node.js
@@ -177,10 +177,10 @@ class Fireworks {
         window.cancelAnimationFrame(this.rafInterval);
     }
     start() {
-        if (this.maxRockets > 0) {
-            this.interval = window.setInterval(() => this.things.spawnRockets(), this.rocketSpawnInterval);
-            this.rafInterval = window.requestAnimationFrame(() => this.update());
-        }
+        if (this.interval != null)
+            return;
+        this.interval = window.setInterval(() => this.things.spawnRockets(), this.rocketSpawnInterval);
+        this.rafInterval = window.requestAnimationFrame(() => this.update());
         return () => this.stop();
     }
     updateDimensions() {

diff --git a/fireworks.node.js.map b/fireworks.node.js.map