Write One Block Phantom Files #83
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ttricco
requested changes
Jul 9, 2024
| from .sarracen_dataframe import SarracenDataFrame | ||
|
|
||
| from .interpolate import interpolate_2d, interpolate_2d_line, interpolate_3d_proj, interpolate_3d_cross | ||
| from .render import render, streamlines, arrowplot | ||
|
|
||
| import sarracen.disc | ||
|
|
||
| __version__ = "1.2.3" | ||
| __version__ = "1.2.4" |
There was a problem hiding this comment.
No need to change the version yet. I do that just before I make an official release.
sarracen/tests/writers/hydro32_00020
Outdated
There was a problem hiding this comment.
Please keep large data files out of the repository. :)
sarracen/tests/writers/jet_00158
Outdated
There was a problem hiding this comment.
Please keep large data files out of the repository. :)
sarracen/tests/writers/ot_00003
Outdated
There was a problem hiding this comment.
Please keep large data files out of the repository. :)
…to accept two dataframes. Commented out "tags = [_rename_duplicate(tag) for tag in tags]" in _write_global_header_tags_and_values as it breaks tests. Need to investigate further - massoptype_7 is expected in header vars, but because of duplicated massoftype due to _rename_duplicate(tag), we have massoftype and massoftype_2 (key error). Might not be relevant in real world files?
…_phantom # Conflicts: # sarracen/readers/read_phantom.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a preliminary pull request to add functionality to create (write) Phantom files from a Sarracen Data Frame. So far, it is functional for data frames that were generated from a single-block Phantom file - we can write a Phantom file from a single data frame. It appears to fail to recreate an accurate Phantom file from the first block (first data frame produced by read_phantom) of a Phantom file, although, visually when rendering the data frames for comparison, the images appears identical.