Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add generic TickDataType #53

Conversation

dominikmaeckel
Copy link
Member

No description provided.

@dominikmaeckel dominikmaeckel self-assigned this Mar 4, 2024
@dominikmaeckel dominikmaeckel added the feature New feature label Mar 4, 2024
@dominikmaeckel dominikmaeckel added this to the v0.3 milestone Mar 4, 2024
Copy link

codecov bot commented Mar 4, 2024

Codecov Report

Attention: Patch coverage is 15.36145% with 281 lines in your changes are missing coverage. Please review.

Project coverage is 26.21%. Comparing base (5a88610) to head (8a8d584).

❗ Current head 8a8d584 differs from pull request most recent head 4d27dfc. Consider uploading reports for the commit 4d27dfc to get more accurate results

Files Patch % Lines
...in/tools/aqua/stars/logic/kcmftbl/minPrevalence.kt 0.00% 33 Missing ⚠️
...ols/aqua/stars/core/evaluation/PredicateContext.kt 0.00% 22 Missing ⚠️
...n/TotalSegmentTickDifferencePerIdentifierMetric.kt 0.00% 19 Missing ⚠️
...ain/kotlin/tools/aqua/stars/logic/kcmftbl/until.kt 0.00% 19 Missing ⚠️
...ain/kotlin/tools/aqua/stars/logic/kcmftbl/since.kt 0.00% 18 Missing ⚠️
...kotlin/tools/aqua/stars/core/tsc/builder/TSCDsl.kt 20.00% 16 Missing ⚠️
.../tools/aqua/stars/core/evaluation/TSCEvaluation.kt 0.00% 15 Missing ⚠️
...main/kotlin/tools/aqua/stars/logic/kcmftbl/next.kt 0.00% 14 Missing ⚠️
...ics/evaluation/TotalSegmentTickDifferenceMetric.kt 0.00% 13 Missing ⚠️
.../kotlin/tools/aqua/stars/logic/kcmftbl/previous.kt 0.00% 12 Missing ⚠️
... and 29 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #53      +/-   ##
==========================================
- Coverage   27.43%   26.21%   -1.22%     
==========================================
  Files         101      103       +2     
  Lines        2253     2281      +28     
  Branches      281      300      +19     
==========================================
- Hits          618      598      -20     
- Misses       1611     1658      +47     
- Partials       24       25       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dominikmaeckel dominikmaeckel enabled auto-merge (squash) March 7, 2024 09:18
@dominikmaeckel dominikmaeckel linked an issue Mar 7, 2024 that may be closed by this pull request
@dominikmaeckel dominikmaeckel merged commit 5f0d6a7 into main Mar 7, 2024
15 checks passed
@dominikmaeckel dominikmaeckel deleted the 33-discuss-change-type-of-currenttick-of-tickdata-from-double-to-long branch March 7, 2024 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update or remove package-info.md files Discuss: Change type of "currentTick" of TickData from Double to Long
2 participants