Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to ch xslt review #19

Closed
wants to merge 4 commits into from

Conversation

lfinnigan
Copy link
Contributor

@cmharlow - i'd love feedback specifically about historicpitt.xsl running against HPtest.xml. I'm trying to include the collection name in the metadata based on the setSpec element higher up in the node hierarchy. I've tried lookups and just a template match, and nothing will work. And now my eyes are crossing.

What I'm looking for is basically -

if //setSpec = 'pitt_collection.72' then add 'dcterms:isPartOfPittsburgh City Photographer Collection</dcterms:isPartOf>' to the metadata. I have a list of setSpec values with their corresponding collection names in a spreadsheet.

@lfinnigan lfinnigan requested a review from cmharlow September 16, 2019 18:46
@cmharlow
Copy link
Contributor

Reviews are in #20 - XSL is working with those repairs. Would strongly recommend getting #14 and other tests PRs in, since some basic unit testing would've caught that this wasn't transforming as expected.

Copy link
Contributor

@cmharlow cmharlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment.

@cmharlow cmharlow closed this Sep 18, 2019
@cmharlow cmharlow deleted the updates-to-ch-xslt-review branch September 19, 2019 01:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants