Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed empty result for jira_issue_comment with id filters Closes #137 #138

Merged
merged 2 commits into from
Sep 25, 2024

Conversation

ParthaI
Copy link
Contributor

@ParthaI ParthaI commented Sep 2, 2024

Example query results

Results
> select title, id, issue_id, body from jira_issue_comment
+-------+-------+----------+--------------------------------------------------------+
| title | id    | issue_id | body                                                   |
+-------+-------+----------+--------------------------------------------------------+
| 10005 | 10005 | 10015    | Joined Sample Sprint 2 1 days 4 hours 10 minutes ago   |
| 10023 | 10023 | 10037    | This is a test comment on 14/09/23                     |
| 10002 | 10002 | 10012    | To Do to In Progress 3 days 21 hours 8 minutes ago     |
| 10015 | 10015 | 10021    | Joined Sample Sprint 1 21 days 10 hours 20 minutes ago |
|       |       |          | To Do to Done 16 days 1 hours 21 minutes ago           |
| 10004 | 10004 | 10014    | Joined Sample Sprint 2 7 days 9 hours 10 minutes ago   |
| 10000 | 10000 | 10008    | Hello                                                  |
| 10012 | 10012 | 10018    | To Do to In Progress 6 days 22 hours 26 minutes ago    |
|       |       |          | In Progress to Done 3 days 16 hours 34 minutes ago     |
| 10011 | 10011 | 10018    | Joined Sample Sprint 2 7 days 9 hours 10 minutes ago   |
| 10006 | 10006 | 10016    | Joined Sample Sprint 2 7 days 9 hours 10 minutes ago   |
| 10007 | 10007 | 10016    | To Do to In Progress 5 days 4 hours 26 minutes ago     |
|       |       |          | In Progress to Done 2 days 18 hours 34 minutes ago     |
| 10003 | 10003 | 10013    | To Do to In Progress 2 days 23 hours 43 minutes ago    |
| 10022 | 10022 | 10001    | in progress                                            |
| 10017 | 10017 | 10023    | Joined Sample Sprint 1 21 days 10 hours 20 minutes ago |
|       |       |          | To Do to Done 11 days 3 hours 23 minutes ago           |
| 10014 | 10014 | 10020    | Joined Sample Sprint 1 21 days 10 hours 20 minutes ago |
|       |       |          | To Do to Done 17 days 13 hours 56 minutes ago          |
| 10018 | 10018 | 10024    | Joined Sample Sprint 1 21 days 10 hours 20 minutes ago |
|       |       |          | To Do to Done 9 days 1 hours 45 minutes ago            |
| 10001 | 10001 | 10011    | Joined Sample Sprint 2 7 days 9 hours 10 minutes ago   |
| 10024 | 10024 | 10053    | this is a test comment for the bug issue               |
| 10016 | 10016 | 10022    | Joined Sample Sprint 1 21 days 10 hours 20 minutes ago |
|       |       |          | To Do to Done 13 days 18 hours 43 minutes ago          |
| 10013 | 10013 | 10019    | Joined Sample Sprint 1 21 days 10 hours 20 minutes ago |
|       |       |          | To Do to Done 20 days 13 hours 50 minutes ago          |
| 10008 | 10008 | 10017    | Created 28 days 5 hours 14 minutes ago                 |
|       |       |          | Joined Sample Sprint 1 21 days 10 hours 20 minutes ago |
| 10010 | 10010 | 10017    | To Do to In Progress 7 days 4 hours 26 minutes ago     |
|       |       |          | In Progress to Done 6 days 2 hours 38 minutes ago      |
| 10009 | 10009 | 10017    | Joined Sample Sprint 2 7 days 9 hours 10 minutes ago   |
+-------+-------+----------+--------------------------------------------------------+

Time: 2.1s. Rows returned: 22. Rows fetched: 22. Hydrate calls: 0.

Scans:
  1) jira_issue_comment.jira: Time: 1.9s. Fetched: 22. Hydrates: 0.

> select title, id, issue_id, body from jira_issue_comment where id = '10005'
+-------+-------+----------+------------------------------------------------------+
| title | id    | issue_id | body                                                 |
+-------+-------+----------+------------------------------------------------------+
| 10005 | 10005 | 10015    | Joined Sample Sprint 2 1 days 4 hours 10 minutes ago |
+-------+-------+----------+------------------------------------------------------+

Time: 2.9s. Rows returned: 1. Rows fetched: 22. Hydrate calls: 0.

Scans:
  1) jira_issue_comment.jira: Time: 2.8s. Fetched: 22. Hydrates: 0. Quals: id=10005.

> select title, id, issue_id, body from jira_issue_comment where issue_id = '10015' 
+-------+-------+----------+------------------------------------------------------+
| title | id    | issue_id | body                                                 |
+-------+-------+----------+------------------------------------------------------+
| 10005 | 10005 | 10015    | Joined Sample Sprint 2 1 days 4 hours 10 minutes ago |
+-------+-------+----------+------------------------------------------------------+

Time: 2.9s. Rows returned: 1. Rows fetched: 1. Hydrate calls: 0.

Scans:
  1) jira_issue_comment.jira: Time: 2.8s. Fetched: 1. Hydrates: 0. Quals: issue_id=10015.

@ParthaI ParthaI self-assigned this Sep 2, 2024
@ParthaI ParthaI linked an issue Sep 2, 2024 that may be closed by this pull request
@dcdamien
Copy link

Hi folks,
@ParthaI @misraved I would kindly ask if will this MR be merged soon?
Ths issue impact is significant for me.

@ParthaI
Copy link
Contributor Author

ParthaI commented Sep 25, 2024

Apologies for the delay in the review process, @dcdamien.

@misraved, could you please take a look at this PR?

@misraved misraved merged commit 33d1895 into main Sep 25, 2024
1 check passed
@misraved misraved deleted the issue-137 branch September 25, 2024 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Empty result for jira_issue_comment with id filters
3 participants