error when not slice

turbot · Nov 20, 2023 · b65784d · b65784d
1 parent cbe797f
commit b65784d
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 2 deletions.
diff --git a/plugin/transform/primitives.go b/plugin/transform/primitives.go
@@ -214,8 +214,10 @@ func NullIfEmptySliceValue(_ context.Context, d *TransformData) (interface{}, er
 		return nil, nil
 	}
 	v := helpers.DereferencePointer(d.Value)
-	b, l := reflect.TypeOf(v).Kind() == reflect.Slice, reflect.ValueOf(v).Len()
-	if b && l == 0 {
+	if reflect.TypeOf(v).Kind() != reflect.Slice {
+		return nil, fmt.Errorf("NullIfEmptySliceValue transform requires the input to be a slice, got %T", v)
+	}
+	if reflect.ValueOf(v).Len() == 0 {
 		return nil, nil
 	}
 	return d.Value, nil

diff --git a/plugin/transform/primitives_test.go b/plugin/transform/primitives_test.go
@@ -807,6 +807,13 @@ Statement:
 		function: NullIfEmptySliceValue,
 		expected: nil,
 	},
+	"NullIfEmptySlice struct": {
+		d: &TransformData{
+			Value: testStruct{},
+		},
+		function: NullIfEmptySliceValue,
+		expected: "ERROR",
+	},
 }
 
 func TestTransformFunctions(t *testing.T) {