Skip to content

Commit

Permalink
Revert "fail-fast if one of the servers have crashed"
Browse files Browse the repository at this point in the history
This reverts commit 0eb860a.
  • Loading branch information
turikhay committed Nov 4, 2024
1 parent cff2247 commit d5ad0aa
Showing 1 changed file with 1 addition and 17 deletions.
18 changes: 1 addition & 17 deletions tests_e2e/run.py
Original file line number Diff line number Diff line change
Expand Up @@ -497,29 +497,13 @@ def save(data):
stderr=STDOUT,
text=True
)
servers_wait = [
docker(
[
'wait',
server,
],
stdout=PIPE,
stderr=STDOUT,
text=True
) for server in servers
]
servers_failed = False

try:
while docker_wait.poll() is None:
ch = docker_logs.stdout.read(1)
if ch:
stdout.buffer.write(ch)
stdout.flush()
if any(map(lambda proc: proc.poll() is not None, servers_wait)):
logger.error("One of the servers have failed")
servers_failed = True
break
except KeyboardInterrupt:
docker_logs.kill()

Expand All @@ -528,7 +512,7 @@ def save(data):
'down',
]).wait()

if servers_failed or docker_wait.returncode != 0 or int(docker_wait.stdout.read()) != 0:
if docker_wait.returncode != 0 or int(docker_wait.stdout.read()) != 0:
logger.error("Failed")
exit(1)

Expand Down

0 comments on commit d5ad0aa

Please sign in to comment.