Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deduplicate output jar files #118

Merged
merged 7 commits into from
Mar 23, 2024
Merged

Deduplicate output jar files #118

merged 7 commits into from
Mar 23, 2024

Conversation

turikhay
Copy link
Owner

@turikhay turikhay commented Mar 22, 2024

Closes #117

New Paper remapper doesn't like duplicate entries in the plugin jar. I came up with a simple and a bit naive solution: we take output of shadowJar and create a new jar with DuplicatesStrategy.EXCLUDE set, and then replace the original one.

EDIT: We should avoid replacing original jar; it's better to just use dedupShadowJar output instead

@turikhay turikhay added the enhancement New feature or request label Mar 22, 2024
@turikhay turikhay merged commit b0a67e8 into main Mar 23, 2024
16 checks passed
@turikhay turikhay deleted the jar-duplicates branch March 23, 2024 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

broken with Paper with CB packge relocation
1 participant