Feature/merchant index coupon count invoice count

README.md

@@ -15,3 +15,8 @@ rails db:schema:dump
 This repo uses a pgdump file to seed the database. Your `db:seed` command will produce lots of output, and that's normal. If all your tests fail after running `db:seed`, you probably forgot to run `rails db:schema:dump`. 
 
 Run your server with `rails s` and you should be able to access endpoints via localhost:3000.
+
+
+![Alt text](LittleShopDiagram.png)
+
+Making edits in order to merge changes to main

app/controllers/api/v1/merchants/coupons_controller.rb

@@ -0,0 +1,54 @@
+class Api::V1::Merchants::CouponsController < ApplicationController
+  rescue_from ActiveRecord::RecordNotFound, with: :record_not_found
+
+ def index
+    active_status = params[:active] 
+    coupons = Coupon.by_merchant(params[:merchant_id], active_status)
+
+    if coupons.present?
+      render json: CouponSerializer.new(coupons), status: :ok
+    else
+      record_not_found
+    end
+  end
+
+
+  def show
+    coupon = Coupon.find_by_merchant_and_id(params[:merchant_id], params[:id])
+    return record_not_found unless coupon
+
+    render json: CouponSerializer.new(coupon), status: :ok
+  end
+
+  def create
+    coupon = Coupon.create_for_merchant(params[:merchant_id], coupon_params)
+    if coupon&.persisted?
+      render json: CouponSerializer.new(coupon), status: :created
+    else
+      render json: ErrorSerializer.format_errors(coupon&.errors&.full_messages || ['Invalid parameters']), status: :unprocessable_entity
+    end
+  end
+
+  def update
+    coupon = Coupon.find_by_merchant_and_id(params[:merchant_id], params[:id])
+    return record_not_found unless coupon
+
+    if coupon.update_with_status(coupon_params)
+      render json: CouponSerializer.new(coupon), status: :ok
+    else
+      render json: ErrorSerializer.format_errors(coupon.errors.full_messages), status: :unprocessable_entity
+    end
+  end
+
+
+  private
+
+  def coupon_params
+    params.require(:coupon).permit(:name, :code, :discount_value, :discount_type, :active)
+  end
+
+
+  def record_not_found
+    render json: ErrorSerializer.format_errors(['Your query could not be completed']), status: :not_found
+  end
+end

app/controllers/api/v1/merchants/invoices_controller.rb

@@ -1,11 +1,10 @@
 class Api::V1::Merchants::InvoicesController < ApplicationController
   def index
     merchant = Merchant.find(params[:merchant_id])
-    if params[:status].present?
-      invoices = merchant.invoices_filtered_by_status(params[:status])
-    else
-      invoices = merchant.invoices
-    end
-    render json: InvoiceSerializer.new(invoices)
+    invoices = merchant.fetch_invoices(params[:status])
+
+    render json: InvoiceSerializer.new(invoices), status: :ok
+  rescue ActiveRecord::RecordNotFound
+    render json: ErrorSerializer.format_errors(['Merchant not found']), status: :not_found
   end
 end

app/models/coupon.rb

@@ -0,0 +1,46 @@
+class Coupon < ApplicationRecord
+  belongs_to :merchant, required: true
+  has_many :invoices
+
+  validates :name, presence: true
+  validates :code, presence: true, uniqueness: true
+  validates :discount_value, presence: true
+  validates :discount_type, inclusion: { in: ["percent", "dollar"] }
+  validate :merchant_cannot_exceed_five_active_coupons, if: :active?
+
+  def self.by_merchant(merchant_id, active_status = nil)
+    coupons = where(merchant_id: merchant_id)
+    coupons = coupons.where(active: active_status) unless active_status.nil?
+    coupons
+  end
+
+  def self.find_by_merchant_and_id(merchant_id, coupon_id)
+    find_by(merchant_id: merchant_id, id: coupon_id)
+  end
+
+  def self.create_for_merchant(merchant_id, params)
+    merchant = Merchant.find_by(id: merchant_id)
+    return nil unless merchant
+    merchant.coupons.create(params)
+  end
+
+  def usage_count
+    invoices.count
+  end
+
+  def update_with_status(params)
+    update(params)
+  end
+
+  private
+
+  def merchant_cannot_exceed_five_active_coupons
+    return unless merchant.present?
+
+    if merchant.coupons.where(active: true).count >= 5
+      errors.add(:base, 'Merchant cannot have more than 5 active coupons')
+    end
+  end
+end
+
+

app/models/invoice.rb

@@ -1,6 +1,7 @@
 class Invoice < ApplicationRecord
   belongs_to :customer
   belongs_to :merchant
+  belongs_to :coupon, optional: true
   has_many :invoice_items, dependent: :destroy
   has_many :transactions, dependent: :destroy
 

app/models/merchant.rb

@@ -3,8 +3,9 @@ class Merchant < ApplicationRecord
   has_many :items, dependent: :destroy
   has_many :invoices, dependent: :destroy
   has_many :customers, through: :invoices
-  # has_many :invoice_items, through: :invoices
-  # has_many :transactions, through: :invoices
+  has_many :invoice_items, through: :invoices
+  has_many :transactions, through: :invoices
+  has_many :coupons
 
   def self.sorted_by_creation
     Merchant.order("created_at DESC")
@@ -14,6 +15,14 @@ def self.filter_by_status(status)
     self.joins(:invoices).where("invoices.status = ?", status).select("distinct merchants.*")
   end
 
+  def coupons_count
+    coupons.count
+  end
+
+  def invoice_coupon_count
+    invoices.where.not(coupon_id: nil).count
+  end
+
   def item_count
     items.count
   end
@@ -35,6 +44,10 @@ def invoices_filtered_by_status(status)
     invoices.where(status: status)
   end
 
+  def fetch_invoices(status = nil)
+    status.present? ? invoices_filtered_by_status(status) : invoices
+  end
+
   def self.find_all_by_name(name)
     Merchant.where("name iLIKE ?", "%#{name}%")
   end

app/serializers/coupon_serializer.rb

@@ -0,0 +1,14 @@
+class CouponSerializer
+  include JSONAPI::Serializer
+
+  set_type :coupon
+  attributes :name, :code, :discount_value, :discount_type, :active, :merchant_id, :usage_count
+
+  attribute :merchant_name do |coupon|
+    coupon.merchant.name
+  end
+
+  attribute :usage_count do |coupon|
+    coupon.usage_count
+  end
+end

app/serializers/error_serializer.rb

@@ -2,14 +2,14 @@ class ErrorSerializer
   def self.format_errors(messages)
     {
       message: 'Your query could not be completed',
-      errors: messages
+      errors: Array(messages)
     }
   end
 
   def self.format_invalid_search_response
-    { 
-      message: "your query could not be completed", 
-      errors: ["invalid search params"] 
+    {
+      message: "your query could not be completed",
+      errors: ["invalid search params"]
     }
   end
-end
+end

app/serializers/invoice_serializer.rb

@@ -1,4 +1,4 @@
 class InvoiceSerializer
   include JSONAPI::Serializer
-  attributes :merchant_id, :customer_id, :status
+  attributes :merchant_id, :customer_id, :status, :coupon_id
 end

app/serializers/merchant_serializer.rb

@@ -7,4 +7,12 @@ class MerchantSerializer
   } do |merchant|
     merchant.item_count
   end
+
+  attribute :coupons_count do |merchant|
+    merchant.coupons_count
+  end
+
+  attribute :invoice_coupon_count do |merchant|
+    merchant.invoice_coupon_count
+  end
 end

config/environments/test.rb

@@ -29,7 +29,7 @@
   config.cache_store = :null_store
 
   # Render exception templates for rescuable exceptions and raise for other exceptions.
-  config.action_dispatch.show_exceptions = :rescuable
+  config.action_dispatch.show_exceptions = :none
 
   # Disable request forgery protection in test environment.
   config.action_controller.allow_forgery_protection = false

config/routes.rb

@@ -24,7 +24,10 @@
         resources :items, only: :index, controller: "merchants/items"
         resources :customers, only: :index, controller: "merchants/customers"
         resources :invoices, only: :index, controller: "merchants/invoices"
+        resources :coupons, only: [:index, :show, :create, :update], controller: "merchants/coupons"
       end
     end
   end
 end
+
+

db/migrate/20241108002837_add_coupons_table.rb

@@ -0,0 +1,14 @@
+class AddCouponsTable < ActiveRecord::Migration[7.1]
+  def change
+    create_table :coupons do |t|
+      t.string :name
+      t.string :code
+      t.float :discount_value
+      t.string :discount_type
+      t.boolean :active, default: true
+      t.references :merchant, null: false, foreign_key: true
+
+      t.timestamps
+    end
+  end
+end

db/migrate/20241108003953_add_coupon_to_invoices.rb

@@ -0,0 +1,6 @@
+class AddCouponToInvoices < ActiveRecord::Migration[7.1]
+  def change
+    add_reference :invoices, :coupon, foreign_key: true, null: true
+  end
+end
+