Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Iteration 2 features - Qory Pull Request # 2 #572

Open
wants to merge 33 commits into
base: main
Choose a base branch
from

Conversation

qoryhanisagal
Copy link

@qoryhanisagal qoryhanisagal commented Oct 23, 2024

Qory # Iteration 2: External Data Integration and Vehicle Creation

Description

This pull request completes Iteration 2 of the DMV project, where external data integration was implemented. Key updates include:

1. DmvDataService Class:

  • Added functionality to retrieve external data sets (e.g., Washington EV registrations).
  • Implemented methods to parse and load data using Faraday and JSON libraries.

2. VehicleFactory Class:

  • Created a new VehicleFactory class to generate Vehicle objects from external data.
  • Dynamically creates Vehicle objects using data fetched from APIs.

3. Test Cases:

  • Added comprehensive tests for:
    • Data parsing and loading in the DmvDataService.
    • Vehicle creation and validation in the VehicleFactory.
    • Ensured all tests from external data integration pass, including validation of vehicle attributes (VIN, make, model, year, engine type).

Changes Made:

  • DmvDataService class: Fetch and process data from multiple sources.
  • VehicleFactory class: Create Vehicle objects from parsed data.
  • Test coverage: Added for external data parsing and vehicle creation.

All previous tests still pass, and this update lays the groundwork for further facility data integration in the next iteration.

…ailed the TDD process and object-oriented design enhancements.
…y and described the feature development process.
…ailed the TDD process and object-oriented design enhancements.
…y and described the feature development process.
…sults, along with reflections on the project.
… registration date, plate type assignment, and fee collection.
…ion for different vehicle types (regular, antique, EV)
…ing engine type, and multiple vehicle registrations
@qoryhanisagal qoryhanisagal changed the title Iteration 2 features Iteration 2 features - Qory # 2 Oct 23, 2024
@qoryhanisagal qoryhanisagal changed the title Iteration 2 features - Qory # 2 Iteration 2 features - Qory Pull Request # 2 Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant