Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

forcing array type before using current() #746

Merged
merged 1 commit into from
Jul 25, 2024
Merged

forcing array type before using current() #746

merged 1 commit into from
Jul 25, 2024

Conversation

aspark21
Copy link
Contributor

Applying current to an object is now deprecated.
Forcing type array before will solve this.

credit @opitz
rebased on develop from ucl-isd#9

jack-tii
jack-tii approved these changes Jul 25, 2024
View reviewed changes
Copy link
Contributor

@jack-tii jack-tii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, doing the same thing as #728. Thanks for the catch!

@jack-tii jack-tii merged commit 9e436b2 into turnitin:develop Jul 25, 2024
@aspark21 aspark21 mentioned this pull request Jul 25, 2024
Open
@aspark21
Copy link
Contributor Author

Ah yes, sorry there's been so many forks and rebases, we did try to get these as PR's as we went along

@aspark21 aspark21 deleted the object branch July 25, 2024 23:45
@aspark21 aspark21 mentioned this pull request Jul 26, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jack-tii jack-tii jack-tii approved these changes

Assignees
No one assigned
Labels
scheduled for next release
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aspark21 @jack-tii