Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bottomless savepoint #1085

Merged
merged 6 commits into from
Mar 4, 2024
Merged

Bottomless savepoint #1085

merged 6 commits into from
Mar 4, 2024

Conversation

Horusiath
Copy link
Contributor

@Horusiath Horusiath commented Feb 26, 2024

This PR introduces a new feature to bottomless - ability to materialise tracker object, that can be awaited for in order to confirm that bottomless asynchronous upload matched the replication status at the moment of method call.

@Horusiath Horusiath force-pushed the bottomless-savepoint branch from f7b719e to 8005d6d Compare February 27, 2024 08:19
@Horusiath Horusiath marked this pull request as ready for review February 27, 2024 08:33
@Horusiath Horusiath requested a review from haaawk February 27, 2024 08:34
Copy link
Contributor

@MarinPostma MarinPostma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

bottomless/src/completion_progress.rs Show resolved Hide resolved
bottomless/src/replicator.rs Show resolved Hide resolved
@Horusiath Horusiath force-pushed the bottomless-savepoint branch from 7808f25 to cad2a44 Compare February 28, 2024 08:30
@MarinPostma MarinPostma added this pull request to the merge queue Feb 29, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 29, 2024
@Horusiath Horusiath mentioned this pull request Mar 4, 2024
12 tasks
@Horusiath Horusiath added this pull request to the merge queue Mar 4, 2024
Merged via the queue into main with commit aa2490c Mar 4, 2024
16 checks passed
@Horusiath Horusiath deleted the bottomless-savepoint branch March 4, 2024 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants