-
Notifications
You must be signed in to change notification settings - Fork 329
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: updated docker instructions #1088
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bryanvaz I'm trying to figure out where more docs go in our docs.turso.tech site for libSQL. I think a new tab "libSQL" at the top of the page might be best that includes info on what libsql is, how to run it with Docker, deploy it, etc. Let me know what you think! |
Thanks Jamie(@notrab)! Yea, based on the current state of libSQL and However, looking at how the docs are setup right now and where Pekka has focused the internal development effort for the local development use-case, I think a more strategic rationalization needs to happen before you can answer the documentation question. Personally, I would say strategically it makes more sense to treat libSQL as part of a continuum, where libSQL is the "community"/self-hosted version, which flows into Turso cloud as the paid tier. You don't want to end up in a situation similar to Gitlab where you have a self-hosted "community" version that no one uses except FOSS evangelists, and a self-hosted "free" enterprise tier that everyone uses (either for scale, cost, or security reasons). MongoDB is probably one of the best examples of a well structured continuum, where it's borderline instinctual for dev teams to use Docker for deterministic local development, and deploy to either Atlas, or Enterprise. Right now, Finally, the docker tags are right now, not stable and do not behave how one would expect (right now on Feb 28,
Once those are pipeline issues and strategic considerations cleaned up, documentation should become alot easier. |
Summary of changes:
DOCKER.md
with new repository locationRationale:
Spent the morning trying to figure out how to get Docker working in deterministic dev environments and ci pipelines. Required digging through source code and issues to realize the docker repo had moved, tags and arch were not the same as other dockerized DBs, and docker persistence documentation was hiding under the build instructions.
This additional documentation should help prevent others from experiencing the same consternation and hopefully reduce friction for adoption in more formal application development settings.
Additional Notes:
Replicas: Replica instructions were based on the original version of the doc and corrected for a typo in the environment variable flag; however I was not able to get the replica to handshake with the primary node. I'll open a separate issue with details on how to recreate.
Arm/Apple Silicon: Since, I assume, the dockerized version is provided out of convenience, but not officially supported by any formal effort, the
arm64
is even less supported. As such, for now I've updated the instructions to recommend using Rosetta if on Apple Silicon, which will comprise the lionshare of thearm64
use-cases, and as release/stable versions only seem to be available inamd64
.