Jw/changing how jwt is passed around

[shopifyski]

Standardized on a structure to pass around auth data instead of expecting downstream code to parse headers
pub struct UserAuthContext { pub scheme: Option<String>, pub token: Option<String>, }

an immediate follow up cleanup should address the following challenges:

• duplication between code in http/user/mod.rs and http/user/extract.rs
• optionality of UserAuthContext fields - when context is required, its fields should not be optional
• tie userauthcontext to the auth strategy. make the strategy define whether certain edge cases (e.g. lack of token) should be interpreted as errors or dismissed

[jeremywrowe]

Love the change! Let me know if you want help resolving some of the todo items. Other than that, I'd recommend moving this one to a normal PR state.

[LucioFranco]

@shopifyski looks like the test CI failures are normal we can just re-run that job, but it looks like you need to run cargo fmt on your changes to get the checks job to pass.

[LucioFranco]

Overall seems like a good change 👍 I left some feedback, feel free to ping me on slack if you have any questions. An additional heads up we are working on cutting a release this week so I will time the merging of this with that, likely after that just to be safe. Let me know if there are any timeline concerns and questions! Thanks!

[LucioFranco]

@shopifyski looks like some checks CI failures that need to be addressed! I just ran ci.

[LucioFranco]

LGTM! Thanks!

[LucioFranco]

Suggested change

	.and_then(|t| UserAuthContext::from_auth_str(t))
	.and_then(UserAuthContext::from_auth_str)

btw if the input type is the same as the closure this works as well!