Improve WAL sync logic #1878
Merged
Improve WAL sync logic #1878
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
penberg
force-pushed
the
improve-wal-sync
branch
2 times, most recently
from
541ac62 to
1086231
Compare
LucioFranco
approved these changes
Dec 12, 2024
MrG9090
approved these changes
Dec 12, 2024
This improves the WAL sync to follow this logic: - If there are no local writes, attempt to pull. We know there are no local writes if the cached remote max frame number is greater than or equal to local max frame number. - If there are local writes, attempt to push. We know there are local writes if the cached remote max number is less than lcoal max frame number. This also removes the `offline_writes_pull.rs` example and augments `offline_writes.rs` to sync before attempting to write.
penberg
force-pushed
the
improve-wal-sync
branch
from
1086231 to
19e7800
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This improves the WAL sync to follow this logic:
If there are no local writes, attempt to pull. We know there are no
local writes if the cached remote max frame number is greater than or
equal to local max frame number.
If there are local writes, attempt to push. We know there are local
writes if the cached remote max number is less than lcoal max frame
number.
This also removes the
offline_writes_pull.rsexample and augmentsoffline_writes.rsto sync before attempting to write.