libsql: add skip_safety_assert builder option
#1906
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a `skip_saftey_assert` builder option that will allow uses to unsafely opt-out of the safety checks that libsql has built in. The inline doc comments for this function explain more.
|
Looks good to me! |
Laerte
reviewed
Jan 9, 2025
| @@ -74,6 +74,7 @@ enum DbType { | |||
| path: String, | |||
| flags: OpenFlags, | |||
| encryption_config: Option<EncryptionConfig>, | |||
| skip_saftey_assert: bool, | |||
There was a problem hiding this comment.
Is this a typo? Title says skip_safety_assert but variable is defined as skip_saftey_assert.
There was a problem hiding this comment.
yeah this is def a typo, but its a private type so we can fix it without worry.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a
skip_saftey_assertbuilder option that will allow uses to unsafely opt-out of the safety checks that libsql has built in. The inline doc comments for this function explain more.