feat(handler, s3store): implement ServerDataStore for direct content serving #1208
Conversation
|
Please note I tried to avoid changing the go version, but This is a draft to get feedback. |
Acconut
changed the title
pcfreak30
force-pushed
the
issue/1064
branch
2 times, most recently
from
6e09111
to
d9e8bca
Compare
|
@Acconut changes have been made. kudos. |
| @@ -121,6 +122,16 @@ type DataStore interface { | |||
| GetUpload(ctx context.Context, id string) (upload Upload, err error) | |||
| } | |||
|
|
|||
| // ServableUpload defines the method for serving content directly | |||
| type ServableUpload interface { | |||
| ServeContent(ctx context.Context, w http.ResponseWriter, r *http.Request) error | |||
There was a problem hiding this comment.
This function needs proper documentation. That's best done when we have agreed on what the handler does and does not.
There was a problem hiding this comment.
lmk what/when you want docs on this.
| // If the data store implements ContentServerDataStore, use the ServableUpload interface | ||
| if handler.composer.UsesContentServer { | ||
| servableUpload := handler.composer.ContentServer.AsServableUpload(upload) | ||
| err = servableUpload.ServeContent(c, w, r) |
There was a problem hiding this comment.
I wonder if the handler should set the Content-Length, Content-Type and Content-Disposition before passing it to ServeContent. The implementation can then decide to overwrite or keep them. The idea is that we already have logic for extracting the filename and filetype from metadata and this way we can keep using them.
pcfreak30
force-pushed
the
issue/1064
branch
from
d9e8bca
to
259cd68
Compare
…ontent serving, closes tus#1064 - Add ServerDataStore interface - Implement ContentServerDataStore in S3Store with streaming support - Add Range header support for partial content requests - Update StoreComposer to support ContentServer capability - Add tests for new ContentServerDataStore functionality - Update Go version to 1.22.1
pcfreak30
force-pushed
the
issue/1064
branch
from
259cd68
to
79384ce
Compare
|
@Acconut changes have been made. |
Closes #1064