Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix back navigation for lectures on tablets #148

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix back navigation for lectures on tablets #148

wants to merge 1 commit into from

Conversation

MichaelRocks
Copy link

Fixes #130 by popping detail fragments from the stack before adding a new one.

@@ -375,7 +375,7 @@ public void openLectureDetail(Lecture lecture, int mDay) {
MyApp.LogDebug(LOG_TAG, "openLectureDetail sidePane=" + sidePane);
if (sidePane != null) {
FragmentManager fm = getSupportFragmentManager();
sidePane.setVisibility(View.VISIBLE);
fm. popBackStack(FragmentTags.DETAIL, FragmentManager.POP_BACK_STACK_INCLUSIVE);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please remove the whitespace here? Please amend the change and force push the branch.

@johnjohndoe
Copy link
Contributor

😸

ligi added a commit to ligi/CampFahrplan that referenced this pull request Dec 17, 2016
Fix back navigation for lectures on tablets
@johnjohndoe
Copy link
Contributor

✅ Merged here: EventFahrplan/EventFahrplan@f9fe5ff

@johnjohndoe
Copy link
Contributor

@MichaelRocks Your pull request has been merged upstream as mentioned above. Please close it here. Thank you for your contribution.

zoff99 pushed a commit to zoff99/CampFahrplan that referenced this pull request Aug 3, 2019
Encapsulate network connectivity observing for different API versions.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants