Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix for IE11 blur event #38

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Bugfix for IE11 blur event #38

wants to merge 2 commits into from

Conversation

jlek
Copy link

@jlek jlek commented Dec 7, 2017

Hello,

First off, thanks for react-tippy. We've been using it for a few months now, and it's great. 👍

I did find a little bug though: on Internet Explorer 11 the blur event does have a relatedTarget property. This meant that a ToolTip with a "focus" trigger would not disappear when the user tabs away from the ToolTip.

This fork works by using the focusout event, rather than the blur event. I am not sure if that is the "correct" fix, but if it is, please accept this pull request. :)

Many thanks,
John

@sethdavis512
Copy link

What is the status on this PR? I'm having IE 11 issues as well...

@jlek
Copy link
Author

jlek commented Feb 26, 2018

I've heard absolutely nothing. :(

@tuanthieu2993
Copy link
Contributor

Thanks for your contribution @jlek,

But has to say when it comes to IE, it's more likely to be its own bug, and in this case, it is. And this PR seems not able to fix it as blur and focusout is the same, the only different is focusout is support event bubbling (http://api.jquery.com/focusout/)

But I have not test on any IE yet so if you can have a test and some results on IE and chrome and Firefox workout with this PR then we could consider merge it as a solution.

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants