Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support pg17 #32

Merged
merged 1 commit into from
Sep 23, 2024
Merged

Support pg17 #32

merged 1 commit into from
Sep 23, 2024

Conversation

thanodnl
Copy link
Collaborator

@thanodnl thanodnl commented Sep 19, 2024

There are no functional changes required for t-digest in pg17, however, test output has changed ever so slightly in the form of

--- /workspaces/tdigest/test/expected/parallel_query.out	2024-08-30 14:04:57.324801940 +0000
+++ /workspaces/tdigest/results/parallel_query.out	2024-09-19 13:36:15.678544507 +0000
@@ -48,7 +48,7 @@
 ------------------------------------------------------
  Subquery Scan on foo
    ->  Finalize Aggregate
-         InitPlan 1 (returns $1)
+         InitPlan 1
            ->  Aggregate
                  ->  Gather
                        Workers Planned: 2

To accommodate for these changes we have added two alternative output files that will make the tests pass.

To ensure compatibility we add pg17 to CI as well. Fixes: #31

@tvondra tvondra merged commit b4b044d into master Sep 23, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Regression tests fail on PG17: plan changes
2 participants