CSS: Introduction of new CSS variables #39091
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What about also introducing a new CSS variable for link decorations? |
| @@ -978,7 +980,9 @@ $form-switch-border-radius: $form-switch-width !default; | |||
| $form-switch-transition: background-position .15s ease-in-out !default; | |||
|
|
|||
| $form-switch-focus-color: $input-focus-border-color !default; | |||
| $form-switch-focus-bg-image: url("data:image/svg+xml,<svg xmlns='http://www.w3.org/2000/svg' viewBox='-4 -4 8 8'><circle r='3' fill='#{$form-switch-focus-color}'/></svg>") !default; | |||
| // fusv-disable | |||
| $form-switch-focus-bg-image: url("data:image/svg+xml,<svg xmlns='http://www.w3.org/2000/svg' viewBox='-4 -4 8 8'><circle r='3' fill='#{$form-switch-focus-color}'/></svg>") !default; // Deprecated in 5.3.2 | |||
There was a problem hiding this comment.
Maybe it should be in a different PR to well separate things.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
PR can be split by commit if needed
Several implementations
I used many ways to introduce this variables, I don't know if you prefer one or another:
var()function. It can be seen in action in the forms.Actual changes
Tried to be as concise as possible for each variable introduced. The bundle size slightly increased but if we change every Sass variable into a CSS var, the bundle would explode. For instance, the CSS variables introduced here only cover the changing properties.
Motivation & Context
Use more CSS variables and be more handful for users.
Type of changes
Checklist
npm run lint)Live previews
Related issues
Should close some items in #35319.
Closes #38202.